mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Subject: Re: specjbb2005 fails with 2.6.29-rc4
Date: Thu, 12 Feb 2009 09:20:44 +0800	[thread overview]
Message-ID: <1234401644.7699.33.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1234401390.7699.29.camel@minggr.sh.intel.com>

On Thu, 2009-02-12 at 09:16 +0800, Lin Ming wrote:
> specjbb2005 fails with 2.6.29-rc4 in many testing machines.
> 
> On a 4*4cores Tigerton machine, run specjb2005 with
> starting_number_warehouses = 1 and ending_number_warehouses = 34.
> It fails when warehouses=16.
> 
> Test with Jrockit VM fails. And it works well if OpenJDK is used
> instead.

Bisect locates below commit.

> 
> commit fc8744adc870a8d4366908221508bb113d8b72ee
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Sat Jan 31 15:08:56 2009 -0800
> 
>     Stop playing silly games with the VM_ACCOUNT flag
>     
>     The mmap_region() code would temporarily set the VM_ACCOUNT flag for
>     anonymous shared mappings just to inform shmem_zero_setup() that it
>     should enable accounting for the resulting shm object.  It would then
>     clear the flag after calling ->mmap (for the /dev/zero case) or doing
>     shmem_zero_setup() (for the MAP_ANON case).
>     
>     This just resulted in vma merge issues, but also made for just
>     unnecessary confusion.  Use the already-existing VM_NORESERVE flag for
>     this instead, and let shmem_{zero|file}_setup() just figure it out from
>     that.
>     
>     This also happens to make it obvious that the new DRI2 GEM layer uses a
>     non-reserving backing store for its object allocation - which is quite
>     possibly not intentional.  But since I didn't want to change semantics
>     in this patch, I left it alone, and just updated the caller to use the
>     new flag semantics.
>     
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
>  drivers/gpu/drm/drm_gem.c |    2 +-
>  ipc/shm.c                 |    4 +-
>  mm/mmap.c                 |   48 +++++++++++++++++++++++---------------------
>  mm/shmem.c                |    2 +-
>  4 files changed, 29 insertions(+), 27 deletions(-)
> 


  reply	other threads:[~2009-02-12  1:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12  1:16 Lin Ming
2009-02-12  1:20 ` Lin Ming [this message]
2009-02-12  1:28   ` Zhang, Yanmin
2009-02-12  1:35 ` Linus Torvalds
2009-02-12  3:23   ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234401644.7699.33.camel@minggr.sh.intel.com \
    --to=ming.m.lin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome