From: Jorg Schummer <ext-jorg.2.schummer@nokia.com>
To: drzeus-mmc@drzeus.cx
Cc: linux-kernel@vger.kernel.org,
Jorg Schummer <ext-jorg.2.schummer@nokia.com>
Subject: [PATCH] MMC: core/core.c: fixed: delayed_work was never cancelled
Date: Tue, 17 Feb 2009 15:32:10 +0200 [thread overview]
Message-ID: <1234877530-28490-1-git-send-email-ext-jorg.2.schummer@nokia.com> (raw)
In-Reply-To: <>
The delayed work item mmc_host.detect is now cancelled before flushing
the work queue. This takes care of cases when delayed_work was scheduled
for mmc_host.detect, but not yet placed in the work queue.
Signed-off-by: Jorg Schummer <ext-jorg.2.schummer@nokia.com>
---
drivers/mmc/core/core.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index f7284b9..2ffae3d 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -57,8 +57,9 @@ static int mmc_schedule_delayed_work(struct delayed_work *work,
/*
* Internal function. Flush all scheduled work from the MMC work queue.
*/
-static void mmc_flush_scheduled_work(void)
+static void mmc_flush_scheduled_work(struct mmc_host *host)
{
+ cancel_delayed_work(&host->detect);
flush_workqueue(workqueue);
}
@@ -738,7 +739,7 @@ void mmc_stop_host(struct mmc_host *host)
spin_unlock_irqrestore(&host->lock, flags);
#endif
- mmc_flush_scheduled_work();
+ mmc_flush_scheduled_work(host);
mmc_bus_get(host);
if (host->bus_ops && !host->bus_dead) {
@@ -765,7 +766,7 @@ void mmc_stop_host(struct mmc_host *host)
*/
int mmc_suspend_host(struct mmc_host *host, pm_message_t state)
{
- mmc_flush_scheduled_work();
+ mmc_flush_scheduled_work(host);
mmc_bus_get(host);
if (host->bus_ops && !host->bus_dead) {
--
1.5.4.3
next reply other threads:[~2009-02-17 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 13:32 Jorg Schummer [this message]
2009-02-18 20:19 ` Pierre Ossman
2009-02-19 11:17 ` [PATCH][take 2] " Jorg Schummer
2009-02-21 16:11 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234877530-28490-1-git-send-email-ext-jorg.2.schummer@nokia.com \
--to=ext-jorg.2.schummer@nokia.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®