From: Patrick Ohly <patrick.ohly@intel.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -mm] documentation: update CodingStyle tips for Emacs users
Date: Wed, 18 Feb 2009 11:23:59 +0100 [thread overview]
Message-ID: <1234952639.23768.32.camel@ecld0pohly> (raw)
In-Reply-To: <20090218095931.GA2054@cmpxchg.org>
On Wed, 2009-02-18 at 09:59 +0000, Johannes Weiner wrote:
[formatting of line continuation in argument list]
> Unfortunately, this seems to depend on the maintainer. Both styles
> are used all over the kernel but Documentation/CodingStyle and
> scripts/checkpatch.pl prefer what the above emacs configuration does.
checkpatch.pl didn't seem to mind either way. I haven't seen this
particular aspect mentioned in the CodingStyle either.
> I doubt that people do tab tab tab space space space space space by
> hand, so I strongly suspect that the tab-only zealots don't use emacs
> which does this adjustment automatically.
>
> You should probably add linux-davem to the above or something. Or
> name the coding style after the text-editor the target maintainer
> uses :-)
One could also get really fancy and extend the path matching to pick the
right style depending on the subdirectory ;-)
Thanks for the clarification. In the future I'll pay closer attention to
existing code and turn the macro on or off accordingly.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2009-02-18 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 17:52 Johannes Weiner
2008-07-04 19:41 ` Jonathan Corbet
2008-07-05 11:36 ` Johannes Weiner
2008-07-05 14:32 ` Jonathan Corbet
2008-07-05 18:33 ` [PATCH -mm] documentation: update CodingStyle tips for Emacs users v2 Johannes Weiner
2009-02-18 9:19 ` [PATCH -mm] documentation: update CodingStyle tips for Emacs users Patrick Ohly
2009-02-18 9:59 ` Johannes Weiner
2009-02-18 10:23 ` Patrick Ohly [this message]
2009-02-18 17:28 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234952639.23768.32.camel@ecld0pohly \
--to=patrick.ohly@intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome