From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756207AbZBRTPU@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756207AbZBRTPU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Feb 2009 14:15:20 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752694AbZBRTPB
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 18 Feb 2009 14:15:01 -0500
Received: from accolon.hansenpartnership.com ([76.243.235.52]:51651 "EHLO
	accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752295AbZBRTPA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Feb 2009 14:15:00 -0500
Subject: Re: [PATCH] pci: enable MSI on 8132
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, david@lang.hm,
       Matthew Wilcox <matthew@wil.cx>,
       Jesse Barnes <jbarnes@virtuousgeek.org>,
       linux-kernel <linux-kernel@vger.kernel.org>, linux-scsi@vger.kernel.org,
       DL-MPTFusionLinux@lsi.com, linux-pci@vger.kernel.org
In-Reply-To: <499C5CAD.1070404@kernel.org>
References: <499B46B2.5040601@kernel.org>
	 <alpine.DEB.1.10.0902171537260.26625@asgard.lang.hm>
	 <499B6BF7.9090300@kernel.org>
	 <alpine.DEB.1.10.0902171803040.26625@asgard.lang.hm>
	 <499B724A.2040408@kernel.org>
	 <alpine.DEB.1.10.0902171832560.26625@asgard.lang.hm>
	 <alpine.DEB.1.10.0902171839420.26625@asgard.lang.hm>
	 <499B774C.5010705@kernel.org>
	 <alpine.DEB.1.10.0902171917420.26625@asgard.lang.hm>
	 <499B9129.50104@kernel.org> <20090218122137.GJ16841@parisc-linux.org>
	 <alpine.DEB.1.10.0902180426420.25606@asgard.lang.hm>
	 <20090218100448.7f7c5b86.akpm@linux-foundation.org>
	 <1234982285.3225.42.camel@localhost.localdomain>
	 <499C5CAD.1070404@kernel.org>
Content-Type: text/plain
Date: Wed, 18 Feb 2009 19:14:55 +0000
Message-Id: <1234984495.3225.48.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2009-02-18 at 11:08 -0800, Yinghai Lu wrote:
> James Bottomley wrote:
> > On Wed, 2009-02-18 at 10:04 -0800, Andrew Morton wrote:
> > 
> >> Do we not need mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch as
> >> well, to fix this regression?
> > 
> > No ... it's a separate issue.  MSI was enabled for fusion SAS in 2.6.26;
> > the problem msi patch which the above corrects actually has the effect
> > of disabling MSI for fusion and went into 2.6.29-rc2, which isn't a
> > kernel that's been tested here.
> > 
> 
> so for 2.6.26, 27, 28 need pci-enable-msi-on-8132.patch

I'm a bit lost with the names, but if that's the PCI quirk fix, then yes

> 2.6.29 need pci-enable-msi-on-8132.patch and mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch

Like I said, I'm happy to have MSI completely disabled until LSI wants
to comment, so no ... only the PCI quirk fix.  The true fix is to have
the drivers participate in dynamic testing of MSI IRQ routing, but I've
somewhat lost sight of that.

James