From: Petr Tesarik <ptesarik@suse.cz>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: remove unneeded endless loop in BUG()
Date: Fri, 20 Feb 2009 09:28:08 +0100 [thread overview]
Message-ID: <1235118488.15053.102.camel@nathan.suse.cz> (raw)
In-Reply-To: <499DC5A6.1080305@zytor.com>
H. Peter Anvin píše v Čt 19. 02. 2009 v 12:48 -0800:
> Jeremy Fitzhardinge wrote:
> >
> > There's no reason to expect an "asm volatile" to stay put; the
> > "volatile" has nothing to do with preventing code motion. The only way
> > to make an asm stick in one place is with data dependencies, and I'm not
> > sure what the dependency for __builtin_trap might be. I'm guessing its
> > a "memory" clobber, but that's pure guesswork.
> >
>
> I looked through this with HJL; the bottom line is that although it
> probably would work, it's not worth it.
>
> I submitted GCC bug 39252 to get __builtin_not_reached(); instead.
Thank you! I like it this way, too.
Petr Tesarik
next prev parent reply other threads:[~2009-02-20 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 18:38 Petr Tesarik
2009-02-19 18:40 ` H. Peter Anvin
2009-02-19 18:59 ` Ingo Molnar
2009-02-19 19:53 ` H. Peter Anvin
2009-02-19 20:47 ` Jeremy Fitzhardinge
2009-02-19 20:48 ` H. Peter Anvin
2009-02-20 8:28 ` Petr Tesarik [this message]
2009-02-19 20:29 ` H. Peter Anvin
2009-02-19 20:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235118488.15053.102.camel@nathan.suse.cz \
--to=ptesarik@suse.cz \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®