From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A954BC32793 for ; Wed, 18 Jan 2023 13:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbjARNUp (ORCPT ); Wed, 18 Jan 2023 08:20:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbjARNUI (ORCPT ); Wed, 18 Jan 2023 08:20:08 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B24856EEA for ; Wed, 18 Jan 2023 04:43:32 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so1138070wmq.1 for ; Wed, 18 Jan 2023 04:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6BpuBHlxhn6JmIP/U1W25BjRcHOubz4Zh2UFAiSQLEU=; b=rg+wQ13Ln8o/vCJ7FCD6BCNg51N0zz+kuwyzGaW+eB4v+6imkHl0IK7w4LKR2Uo8Z8 cREXzPewR/gI3wmeRBQ4u8h9Y5+LnHNYPAguubutmhE8JS8u6XL8sPNsk+plB25evzQ6 APUctgRkDq4sA0ba8vY+6VSdcXcyrNYO0niw91fhP947VngxcakHwRL7sTvSTSt7dlqa Fs/IVyKND7ciFfABFf4j404xOPm10MMb8JbvAGJEQhTdP1tav6nIUPDfm+tsrPFwA+En mrLBGRG7mQVfngUt/E7tjhBnKxl/gNJe/oiUoFq2jfMwQC8EPZxa/YsaxU4gZ+ZfDM5V gIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6BpuBHlxhn6JmIP/U1W25BjRcHOubz4Zh2UFAiSQLEU=; b=IMK278c2zdR2Yt5TCPtuMqA3S6LkDFuCMWDCdJIeF3FAhyjuFjwbqVpTXcLELeAUkJ pgwO7aAAyXvw3adV6BoBQTuJgIHiNwHnB5pOnmf69vMCoZegFCXeMc4YQTatrv2tvvRA l6N9q2tXaQDqGMNnTGLffZWUZBzhRlMo3+nvb7JKbybJEM0HjngWpd+axMjetJpXr3Vv 1o/wv/PJ82sUVyJn8lyNF0nlhBqKAqXwB1fjRg8M3PngQ9CGseESSvc79GlIHyyhdaDU jwKZ7NroZQIP7/poYJnDMcLeUPC2JRXKQRa/5rL95opqgyL7U7D8t25qb9rGD/gQcVNZ FTZQ== X-Gm-Message-State: AFqh2krlGRqc2T7YMZt9VGdv5wK4y2gwUfu8NIqtVKMbLfA6eI26EaDo K3Vt4OpgGegmg+/q0b0MiIWKYQ== X-Google-Smtp-Source: AMrXdXv8u/F/eZG9dc2ocylK99J6Wri4Y6XHkV4l8TM6VnWGG7uhxyezbZ27wJeJ5jUWJwtppSpVDw== X-Received: by 2002:a05:600c:3b05:b0:3d6:b691:b80d with SMTP id m5-20020a05600c3b0500b003d6b691b80dmr6536563wms.21.1674045810989; Wed, 18 Jan 2023 04:43:30 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c10-20020a05600c0a4a00b003db12112fcfsm1954912wmq.4.2023.01.18.04.43.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jan 2023 04:43:30 -0800 (PST) Message-ID: <12358dd7-d600-0b2c-96ab-518ee2e65404@linaro.org> Date: Wed, 18 Jan 2023 13:43:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 03/19] dt-bindings: bus: add CDX bus controller device tree bindings Content-Language: en-US To: "Gupta, Nipun" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "eric.auger@redhat.com" , "alex.williamson@redhat.com" , "cohuck@redhat.com" , "song.bao.hua@hisilicon.com" , "mchehab+huawei@kernel.org" , "maz@kernel.org" , "f.fainelli@gmail.com" , "jeffrey.l.hugo@gmail.com" , "saravanak@google.com" , "Michael.Srba@seznam.cz" , "mani@kernel.org" , "yishaih@nvidia.com" , "jgg@ziepe.ca" , "jgg@nvidia.com" , "robin.murphy@arm.com" , "will@kernel.org" , "joro@8bytes.org" , "masahiroy@kernel.org" , "ndesaulniers@google.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Cc: "okaya@kernel.org" , "Anand, Harpreet" , "Agarwal, Nikhil" , "Simek, Michal" , "git (AMD-Xilinx)" References: <20230117134139.1298-1-nipun.gupta@amd.com> <20230117134139.1298-4-nipun.gupta@amd.com> <5ebee797-aa87-8db4-228c-dfe236ad32f8@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/2023 13:39, Gupta, Nipun wrote: > [AMD Official Use Only - General] Fix your email client. This is not helping us. What shall I do with it? > > > (...) >>> +properties: >>> + compatible: >>> + const: xlnx,cdxbus-controller >> >> This misses SoC specific compatible. Drop "bus" - redundant. I would >> also say - drop controller - do you see any other devices with such >> compatible naming? Use naming consistent with other devices in the >> kernel. Just open some controllers - SPI, I2C etc. and look there. > > Makes sense. Will use "xlnx,cdx" in compatible. No, this still misses device specific compatible. You did ignored half of my comment now. Best regards, Krzysztof