mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Smith <danms@us.ibm.com>
To: containers@lists.osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] c/r: Add CR_COPY() macro (v3)
Date: Tue,  3 Mar 2009 10:56:03 -0500	[thread overview]
Message-ID: <1236095764-19325-3-git-send-email-danms@us.ibm.com> (raw)
In-Reply-To: <1236095764-19325-1-git-send-email-danms@us.ibm.com>

As suggested by Dave[1], this provides us a way to make the copy-in and
copy-out processes symmetric.  CR_COPY_ARRAY() provides us a way to do
the same thing but for arrays.  It's not critical, but it helps us unify
the checkpoint and restart paths for some things.

Changelog:
    Feb 27:
            . Changed CR_COPY() to use assignment, eliminating the need
              for the CR_COPY_BIT() macro
            . Add CR_COPY_ARRAY() macro to help copying register arrays,
              etc
            . Move the macro definitions inside the CR #ifdef
    Feb 25:
            . Changed WARN_ON() to BUILD_BUG_ON()

Signed-off-by: Dan Smith <danms@us.ibm.com>

1: https://lists.linux-foundation.org/pipermail/containers/2009-February/015821.html (all the way at the bottom)
---
 include/linux/checkpoint.h |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/include/linux/checkpoint.h b/include/linux/checkpoint.h
index 217cf6e..735668f 100644
--- a/include/linux/checkpoint.h
+++ b/include/linux/checkpoint.h
@@ -142,6 +142,26 @@ static inline void __task_deny_checkpointing(struct task_struct *task,
 #define task_deny_checkpointing(p)  \
 	__task_deny_checkpointing(p, __FILE__, __LINE__)
 
+#define CR_CPT 1
+#define CR_RST 2
+
+#define CR_COPY(op, a, b)				        \
+	do {							\
+		if (op == CR_CPT)				\
+			a = b;					\
+		else						\
+			b = a;					\
+	} while (0);
+
+#define CR_COPY_ARRAY(op, a, b, count)				\
+	do {							\
+		BUILD_BUG_ON(sizeof(*a) != sizeof(*b));		\
+		if (op == CR_CPT)				\
+			memcpy(a, b, count * sizeof(*a));	\
+		else						\
+			memcpy(b, a, count * sizeof(*a));	\
+	} while (0);
+
 #else
 
 static inline void task_deny_checkpointing(struct task_struct *task) {}
-- 
1.6.1


  parent reply	other threads:[~2009-03-03 15:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03 15:56 [PATCH 0/3] c/r: Add s390 support Dan Smith
2009-03-03 15:56 ` [PATCH 1/3] s390: Expose a constant for the number of words representing the CRs Dan Smith
2009-03-03 16:08   ` Dave Hansen
2009-03-04  0:56     ` Dan Smith
2009-03-04  0:59       ` Dave Hansen
2009-03-03 15:56 ` Dan Smith [this message]
2009-03-03 16:22   ` [PATCH 2/3] c/r: Add CR_COPY() macro (v3) Dave Hansen
2009-03-04  0:57     ` Dan Smith
2009-03-04  1:00       ` Dave Hansen
2009-03-04 15:05         ` Serge E. Hallyn
2009-03-18  7:51           ` Oren Laadan
2009-03-18 13:43             ` Serge E. Hallyn
2009-03-04 19:53         ` Nathan Lynch
2009-03-04 20:18           ` Dave Hansen
2009-03-04 20:01   ` Nathan Lynch
2009-03-04 20:18     ` Dan Smith
2009-03-03 15:56 ` [PATCH 3/3] c/r: define s390-specific checkpoint-restart code (v7) Dan Smith
2009-03-03 22:40   ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236095764-19325-3-git-send-email-danms@us.ibm.com \
    --to=danms@us.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®