Re: [PATCH 2/3] crypto: Add fpu template, a wrapper for blkcipher touching FPU

[Huang Ying <ying.huang@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

On Thu, 2009-03-05 at 19:54 +0800, Sebastian Andrzej Siewior wrote:
> * Huang Ying | 2009-03-05 10:25:41 [+0800]:
> 
> >Blkcipher touching FPU need to be enclosed by kernel_fpu_begin() and
> >kernel_fpu_end(). If they are invoked in cipher algorithm
> >implementation, they will be invoked for each block, so that
> >performance will be hurt, because they are "slow" operations. This
> >patch implements "fpu" template, which makes these operations to be
> >invoked for each request.
> >
> >Signed-off-by: Huang Ying <ying.huang@intel.com>
> >
> >---
> > crypto/Kconfig  |    7 ++
> > crypto/Makefile |    1 
> > crypto/fpu.c    |  166 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 174 insertions(+)
> >
> >--- a/crypto/Kconfig
> >+++ b/crypto/Kconfig
> >@@ -236,6 +236,13 @@ config CRYPTO_XTS
> > 	  key size 256, 384 or 512 bits. This implementation currently
> > 	  can't handle a sectorsize which is not a multiple of 16 bytes.
> > 
> >+config CRYPTO_FPU
> >+	tristate "FPU wrapper"
> >+	select CRYPTO_BLKCIPHER
> >+	select CRYPTO_MANAGER
> >+	help
> >+	  FPU: Wrapper for blkcipher touching FPU.
> I as an end-user have to clue what this could be about. I suggest you
> don't make it visible since the explanation won't be helpfull either :)

Yes. That's better. I will change it.

Best Regards,
Huang Ying

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]