From: Ben Hutchings <bhutchings@solarflare.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: build bug on kfree(struct sk_buff*)
Date: Sun, 15 Mar 2009 19:33:28 +0000 [thread overview]
Message-ID: <1237145608.4209.49.camel@hashbaz.i.decadent.org.uk> (raw)
In-Reply-To: <49BD2FDF.5050504@gmail.com>
On Sun, 2009-03-15 at 17:42 +0100, Roel Kluin wrote:
> I noticed that my initial attempt was invalid. The one below appears to be
> correct, although I am not sure whether there is a better implementation.
>
> this patch also fixes a kfree(skb) in net/core/dev.c, what do you think?
[...]
There are many types that should not be allocated and freed using the
general-purpose heap functions. Why provide this check only for struct
skbuff?
Perhaps you should try to find a general way of detecting this, such as
a type annotation for sparse.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2009-03-15 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 16:17 build bug on pointer type Roel Kluin
2009-03-13 23:16 ` build bug on kfree(struct sk_buff*) Roel Kluin
2009-03-15 16:42 ` Roel Kluin
2009-03-15 19:33 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237145608.4209.49.camel@hashbaz.i.decadent.org.uk \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome