mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: Don't increment use_count for boot_on regulators
Date: Thu, 19 Mar 2009 18:09:00 +0000	[thread overview]
Message-ID: <1237486140.6781.340.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <1237232194-24113-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Mon, 2009-03-16 at 19:36 +0000, Mark Brown wrote:
> Don't set use_count for regulators that are enabled at boot since this
> stops the supply being disabled by well-behaved consumers which do
> balanced enables and disabled. Any consumers which don't do disables
> which are not matched by enables are unable to share regulators - shared
> regulators are the common case so the API should facilitate them.
> 
> Consumers that want to disable regulators that are enabled when they
> start have two options:
> 
>  - Do a regulator_enable() prior to the disable to bring the use count
>    in sync with the hardware state; this will ensure that if the
>    regulator was enabled by another driver then this consumer will play
>    nicely with it.
>  - Use regulator_force_disable(); this explicitly bypasses any checks
>    done by the core and documents the inability of the driver to share
>    the supply.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/regulator/core.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Applied.

Thanks

Liam


      parent reply	other threads:[~2009-03-19 18:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 19:36 Mark Brown
2009-03-16 19:36 ` [PATCH 2/2] regulator: Support disabling of unused regulators by machines Mark Brown
2009-03-19 18:09   ` Liam Girdwood
2009-03-19 18:09 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237486140.6781.340.camel@vega.slimlogic.co.uk \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®