From: Luotao Fu <l.fu@pengutronix.de>
To: alsa-devel@alsa-project.org
Cc: dbaryshkov@gmail.com, linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com,
Luotao Fu <l.fu@pengutronix.de>
Subject: [RESEND] [PATCH] pxa2xx-ac97: fix displaying GSR after reset timeout
Date: Tue, 24 Mar 2009 17:25:28 +0100 [thread overview]
Message-ID: <1237911929-29895-1-git-send-email-l.fu@pengutronix.de> (raw)
In-Reply-To: <gq8unj$6og$1@ger.gmane.org>
the variable gsr_bit is set in isr. It is however set to 0 and interrupts are
disabled prior to reset on pxa27x and pxa3xx. Hence it doesn't make a lot of
sense to show the content of gsr_bit in case of a reset timeout.
Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
---
sound/arm/pxa2xx-ac97-lib.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index 35afd0c..25933ba 100644
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -218,7 +218,7 @@ bool pxa2xx_ac97_try_warm_reset(struct snd_ac97 *ac97)
if (!((GSR | gsr_bits) & (GSR_PCR | GSR_SCR))) {
printk(KERN_INFO "%s: warm reset timeout (GSR=%#lx)\n",
- __func__, gsr_bits);
+ __func__, GSR | gsr_bits);
return false;
}
@@ -248,7 +248,7 @@ bool pxa2xx_ac97_try_cold_reset(struct snd_ac97 *ac97)
if (!((GSR | gsr_bits) & (GSR_PCR | GSR_SCR))) {
printk(KERN_INFO "%s: cold reset timeout (GSR=%#lx)\n",
- __func__, gsr_bits);
+ __func__, GSR | gsr_bits);
return false;
}
--
1.5.6.5
next parent reply other threads:[~2009-03-24 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gq8unj$6og$1@ger.gmane.org>
2009-03-24 16:25 ` Luotao Fu [this message]
2009-03-24 22:18 ` Russell King - ARM Linux
2009-03-25 10:34 ` [alsa-devel] " Mark Brown
2009-03-26 12:18 ` Luotao Fu
2009-03-26 14:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237911929-29895-1-git-send-email-l.fu@pengutronix.de \
--to=l.fu@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®