From: stoyboyker@gmail.com
To: linux-kernel@vger.kernel.org
Cc: Stoyan Gaydarov <stoyboyker@gmail.com>, perex@perex.cz, tiwai@suse.de
Subject: [PATCH 03/13] [oss] changed ioctls to unlocked
Date: Tue, 24 Mar 2009 16:12:38 -0500 [thread overview]
Message-ID: <1237929168-15341-4-git-send-email-stoyboyker@gmail.com> (raw)
From: Stoyan Gaydarov <stoyboyker@gmail.com>
Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
---
sound/oss/sh_dac_audio.c | 60 ++++++++++++++++++++++++++++++---------------
1 files changed, 40 insertions(+), 20 deletions(-)
diff --git a/sound/oss/sh_dac_audio.c b/sound/oss/sh_dac_audio.c
index e5d4239..22ae271 100644
--- a/sound/oss/sh_dac_audio.c
+++ b/sound/oss/sh_dac_audio.c
@@ -111,35 +111,43 @@ static void dac_audio_set_rate(void)
ctrl_outl(interval, TMU1_TCNT);
}
-static int dac_audio_ioctl(struct inode *inode, struct file *file,
- unsigned int cmd, unsigned long arg)
+static long dac_audio_ioctl(struct file *file, unsigned int cmd,
+ unsigned long arg)
{
int val;
+ long ret;
switch (cmd) {
case OSS_GETVERSION:
- return put_user(SOUND_VERSION, (int *)arg);
+ ret = put_user(SOUND_VERSION, (int *)arg);
+ break;
case SNDCTL_DSP_SYNC:
dac_audio_sync();
- return 0;
+ ret = 0;
+ break;
case SNDCTL_DSP_RESET:
dac_audio_reset();
- return 0;
+ ret = 0;
+ break;
case SNDCTL_DSP_GETFMTS:
- return put_user(AFMT_U8, (int *)arg);
+ ret = put_user(AFMT_U8, (int *)arg);
+ break;
case SNDCTL_DSP_SETFMT:
- return put_user(AFMT_U8, (int *)arg);
+ ret = put_user(AFMT_U8, (int *)arg);
+ break;
case SNDCTL_DSP_NONBLOCK:
file->f_flags |= O_NONBLOCK;
- return 0;
+ ret = 0;
+ break;
case SNDCTL_DSP_GETCAPS:
- return 0;
+ ret = 0;
+ break;
case SOUND_PCM_WRITE_RATE:
val = *(int *)arg;
@@ -147,32 +155,44 @@ static int dac_audio_ioctl(struct inode *inode, struct file *file,
rate = val;
dac_audio_set_rate();
}
- return put_user(rate, (int *)arg);
+ ret = put_user(rate, (int *)arg);
+ break;
case SNDCTL_DSP_STEREO:
- return put_user(0, (int *)arg);
+ ret = put_user(0, (int *)arg);
+ break;
case SOUND_PCM_WRITE_CHANNELS:
- return put_user(1, (int *)arg);
+ ret = put_user(1, (int *)arg);
+ break;
case SNDCTL_DSP_SETDUPLEX:
- return -EINVAL;
+ ret = -EINVAL;
+ break;
case SNDCTL_DSP_PROFILE:
- return -EINVAL;
+ ret = -EINVAL;
+ break;
case SNDCTL_DSP_GETBLKSIZE:
- return put_user(BUFFER_SIZE, (int *)arg);
+ ret = put_user(BUFFER_SIZE, (int *)arg);
+ break;
case SNDCTL_DSP_SETFRAGMENT:
- return 0;
+ ret = 0;
+ break;
default:
printk(KERN_ERR "sh_dac_audio: unimplemented ioctl=0x%x\n",
cmd);
- return -EINVAL;
+ ret = -EINVAL;
+ break;
}
- return -EINVAL;
+ if(!ret)
+ ret = -EINVAL;
+
+ unlock_kernel();
+ return ret;
}
static ssize_t dac_audio_write(struct file *file, const char *buf, size_t count,
@@ -257,8 +277,8 @@ static int dac_audio_release(struct inode *inode, struct file *file)
const struct file_operations dac_audio_fops = {
.read = dac_audio_read,
- .write = dac_audio_write,
- .ioctl = dac_audio_ioctl,
+ .write = dac_audio_write,
+ .unlocked_ioctl = dac_audio_ioctl,
.open = dac_audio_open,
.release = dac_audio_release,
};
--
1.6.2
next reply other threads:[~2009-03-24 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:12 stoyboyker [this message]
2009-04-06 1:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237929168-15341-4-git-send-email-stoyboyker@gmail.com \
--to=stoyboyker@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®