From: Eric Anholt <eric@anholt.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: DRM lock ordering fix series
Date: Sun, 29 Mar 2009 23:29:32 -0700 [thread overview]
Message-ID: <1238394572.9782.13.camel@gaiman.anholt.net> (raw)
In-Reply-To: <1238203799.4039.437.camel@laptop>
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On Sat, 2009-03-28 at 02:29 +0100, Peter Zijlstra wrote:
> On Sat, 2009-03-28 at 01:58 +0100, Peter Zijlstra wrote:
>
> > > OK. I'm not too excited here -- 10% of 2% of the CPU time doesn't get
> > > me to the 10% loss that the slow path added up to. Most of the cost is
> > > in k{un,}map_atomic of the returned pages.
> >
> > Also note that doing large gup() with gup_fast() will be undesirable due
> > to it disabling IRQs. So iterating say several MB worth of pages will
> > hurt like crazy. Currently all gup_fast() users do a single page lookup.
>
> Also, what's this weird facination with 32bit, can you even buy a 32bit
> only cpu these days?
I work on OpenGL. Many people using OpenGL want to play commercial
games. Commercial games are 32-bit. sysprof doesn't work for 32-on-64,
so I'd lose a critical tool. Thus, 32-only.
keithp runs 32-on-64, and just about every day we're working together,
we lament that he can't run sysprof on his box. Getting ~10% of my CPU
back by going 32-on-64 would be nice, but it's not worth not being able
to usefully profile.
--
Eric Anholt
eric@anholt.net eric.anholt@intel.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-03-30 6:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 21:45 Eric Anholt
2009-03-25 21:45 ` [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path Eric Anholt
2009-03-25 21:45 ` [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free Eric Anholt
2009-03-25 21:45 ` [PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path Eric Anholt
2009-03-25 21:45 ` [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path Eric Anholt
2009-03-25 21:45 ` [PATCH 5/6] drm/i915: Fix lock order reversal with cliprects and cmdbuf in non-DRI2 paths Eric Anholt
2009-03-25 21:45 ` [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation entry copying Eric Anholt
2009-03-30 10:00 ` [PATCH 6/6] drm/i915: Fix lock order reversal in GEM relocation entry copying. -- makes X hang Florian Mickler
2009-03-31 19:36 ` Eric Anholt
2009-04-01 0:12 ` Florian Mickler
2009-03-27 0:52 ` [PATCH 5/6] drm/i915: Fix lock order reversal with cliprects and cmdbuf in non-DRI2 paths Jesse Barnes
2009-03-25 23:30 ` [PATCH 4/6] drm/i915: Fix lock order reversal in shmem pread path Dave Airlie
2009-03-26 4:03 ` Keith Packard
2009-03-27 0:50 ` Jesse Barnes
2009-03-27 0:50 ` [PATCH 3/6] drm/i915: Fix lock order reversal in shmem pwrite path Jesse Barnes
2009-03-25 22:52 ` [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted instead of get/free Dave Airlie
2009-03-26 19:59 ` Eric Anholt
2009-03-27 0:47 ` Jesse Barnes
2009-03-27 0:43 ` [PATCH 1/6] drm/i915: Fix lock order reversal in GTT pwrite path Jesse Barnes
2009-03-27 16:56 ` Eric Anholt
2009-03-27 17:07 ` Jesse Barnes
2009-03-28 0:54 ` Peter Zijlstra
2009-03-28 2:35 ` Jesse Barnes
2009-03-28 5:22 ` Dave Airlie
2009-03-27 9:34 ` DRM lock ordering fix series Andi Kleen
2009-03-27 16:19 ` Eric Anholt
2009-03-27 16:36 ` Eric Anholt
2009-03-27 18:10 ` Andi Kleen
2009-03-27 20:10 ` Eric Anholt
2009-03-27 21:05 ` Andi Kleen
2009-03-28 0:58 ` Peter Zijlstra
2009-03-28 1:29 ` Peter Zijlstra
2009-03-30 6:29 ` Eric Anholt [this message]
2009-03-28 8:46 ` Brice Goglin
2009-03-28 10:48 ` Peter Zijlstra
2009-03-28 12:22 ` [RFC] x86: gup_fast() batch limit (was: DRM lock ordering fix series) Peter Zijlstra
2009-03-28 12:46 ` Peter Zijlstra
2009-04-02 11:19 ` Nick Piggin
2009-06-24 13:46 ` [RFC] x86: gup_fast() batch limit Brice Goglin
2009-06-24 17:07 ` Peter Zijlstra
2009-06-24 19:55 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238394572.9782.13.camel@gaiman.anholt.net \
--to=eric@anholt.net \
--cc=andi@firstfloor.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®