From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Martin Bligh <mbligh@google.com>,
linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: [patch 1/3] slub: add per-cache slab thrash ratio
Date: Mon, 30 Mar 2009 10:11:31 +0300 [thread overview]
Message-ID: <1238397091.26742.35.camel@penberg-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.0903292242510.15813@chino.kir.corp.google.com>
On Sun, 2009-03-29 at 22:43 -0700, David Rientjes wrote:
> The slab_thrash_ratio for each cache do not have non-zero defaults
> (yet?).
If we're going to merge this code, I think it would be better to put a
non-zero default there; otherwise we won't be able to hit potential
performance regressions or bugs. Furthermore, the optimization is not
very useful on large scale if people need to enable it themselves.
Maybe stick 20 there and run tbench, sysbench, et al to see if it makes
a difference? I'm cc'ing Mel in case he has some suggestions how to test
it.
Pekka
next prev parent reply other threads:[~2009-03-30 7:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 5:43 [patch 0/3] slub partial list thrashing performance degradation David Rientjes
2009-03-30 5:43 ` [patch 1/3] slub: add per-cache slab thrash ratio David Rientjes
2009-03-30 5:43 ` [patch 2/3] slub: scan partial list for free slabs when thrashing David Rientjes
2009-03-30 5:43 ` [patch 3/3] slub: sort parital list " David Rientjes
2009-03-30 14:41 ` Christoph Lameter
2009-03-30 20:29 ` David Rientjes
2009-03-30 14:37 ` [patch 2/3] slub: scan partial list for free slabs " Christoph Lameter
2009-03-30 20:22 ` David Rientjes
2009-03-30 21:20 ` Christoph Lameter
2009-03-31 7:13 ` Pekka Enberg
2009-03-31 8:23 ` David Rientjes
2009-03-31 8:49 ` Pekka Enberg
2009-03-31 13:23 ` Christoph Lameter
2009-03-30 7:11 ` Pekka Enberg [this message]
2009-03-30 8:41 ` [patch 1/3] slub: add per-cache slab thrash ratio David Rientjes
2009-03-30 15:54 ` Mel Gorman
2009-03-30 20:38 ` David Rientjes
2009-03-30 14:30 ` Christoph Lameter
2009-03-30 20:12 ` David Rientjes
2009-03-30 21:19 ` Christoph Lameter
2009-03-30 22:48 ` David Rientjes
2009-03-31 4:44 ` David Rientjes
2009-03-31 13:26 ` Christoph Lameter
2009-03-31 17:21 ` David Rientjes
2009-03-31 17:24 ` Christoph Lameter
2009-03-31 17:35 ` David Rientjes
2009-03-30 6:38 ` [patch 0/3] slub partial list thrashing performance degradation Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2009-03-26 9:42 [patch 1/3] slub: add per-cache slab thrash ratio David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238397091.26742.35.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=mel@csn.ul.ie \
--cc=nickpiggin@yahoo.com.au \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®