From: Suresh Siddha <suresh.b.siddha@intel.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Han, Weidong" <weidong.han@intel.com>,
Ingo Molnar <mingo@elte.hu>,
"Kay, Allen M" <allen.m.kay@intel.com>,
IOMMU <iommu@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/2] x2apic/intr-remap: decouple interrupt remapping from x2apic
Date: Fri, 03 Apr 2009 10:10:35 -0800 [thread overview]
Message-ID: <1238782235.27006.7868.camel@localhost.localdomain> (raw)
In-Reply-To: <1238782131.3494.66.camel@macbook.infradead.org>
On Fri, 2009-04-03 at 11:08 -0700, David Woodhouse wrote:
> On Fri, 2009-04-03 at 09:57 -0800, Suresh Siddha wrote:
> > On Fri, 2009-04-03 at 02:15 -0700, Han, Weidong wrote:
> > >
> > > -#ifdef CONFIG_INTR_REMAP
> > > +#ifdef CONFIG_X86_X2APIC
> >
> > Weidong, Can we also fix these config options?
> >
> > Today, selecting CONFIG_INTR_REMAP automatically selects
> > CONFIG_X86_X2APIC. It should be the other way round.
> >
> > i.e., turning on CONFIG_X86_X2APIC should automatically enable
> > CONFIG_INTR_REMAP and just enabling CONFIG_INTR_REMAP shouldn't enable
> > CONFIG_X86_X2APIC.
> >
> > Also please make sure that the code compiles (and works :)) in different
> > combinations of these config settings.
>
> Which should SGI Ultraviolet be selecting?
Both X2APIC and INTR_REMAP. They already select X2APIC today. With above
change, they automatically get INTR_REMAP too.
next prev parent reply other threads:[~2009-04-03 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-03 9:15 Han, Weidong
2009-04-03 17:57 ` Suresh Siddha
2009-04-03 18:08 ` David Woodhouse
2009-04-03 18:10 ` Suresh Siddha [this message]
2009-04-04 3:37 ` Han, Weidong
2009-04-04 8:28 ` David Woodhouse
2009-04-04 8:48 ` Han, Weidong
2009-04-04 9:07 ` David Woodhouse
2009-04-04 9:15 ` David Woodhouse
2009-04-04 9:21 ` Han, Weidong
2009-04-04 9:46 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238782235.27006.7868.camel@localhost.localdomain \
--to=suresh.b.siddha@intel.com \
--cc=allen.m.kay@intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®