mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: intel-iommu: Add for_each_iommu() and for_each_active_iommu() macros
Date: Mon, 06 Apr 2009 19:58:14 -0700	[thread overview]
Message-ID: <1239073094.22733.267.camel@macbook.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0904062127420.24008@gandalf.stny.rr.com>

On Mon, 2009-04-06 at 21:29 -0400, Steven Rostedt wrote:
> If this works then (after reformating)
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Yeah, it seems to work. This worried me briefly for a while but then I
realised it was already there before my changes...

[dwmw2@macbook linux-2.6]$ grep CONFIG_PROFILE_ALL_BRANCHES .config
# CONFIG_PROFILE_ALL_BRANCHES is not set
[dwmw2@macbook linux-2.6]$ make drivers/net/e100.o
scripts/kconfig/conf -s arch/x86/Kconfig
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CC      kernel/bounds.s
  GEN     include/linux/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
  GEN     include/asm/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CC      drivers/net/e100.o
[dwmw2@macbook linux-2.6]$ sed -i 's/.*\(CONFIG_PROFILE_ALL_BRANCHES\).*/\1=y/' .config
[dwmw2@macbook linux-2.6]$ make drivers/net/e100.oscripts/kconfig/conf -s arch/x86/Kconfig
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CC      kernel/bounds.s
  GEN     include/linux/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
  GEN     include/asm/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CC      drivers/net/e100.o
drivers/net/e100.c: In function ‘e100_hw_init’:
drivers/net/e100.c:1344: warning: ‘err’ may be used uninitialized in this function


This happens in a lot of places, not just e100.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


  reply	other threads:[~2009-04-07  2:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904062159.n36Lx1OJ001967@hera.kernel.org>
2009-04-07  0:59 ` Andrew Morton
2009-04-07  1:09   ` David Woodhouse
2009-04-07  1:19     ` David Woodhouse
2009-04-07  1:24       ` Andrew Morton
2009-04-07  1:29       ` Steven Rostedt
2009-04-07  2:58         ` David Woodhouse [this message]
2009-04-07  3:02           ` Steven Rostedt
2009-04-07  3:29         ` David Woodhouse
2009-04-08 11:00     ` Ingo Molnar
2009-04-09  0:42       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239073094.22733.267.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®