From: Pekka Enberg <penberg@cs.helsinki.fi>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>
Subject: [PATCH 08/11] w35und: inline hal_set_phy_type() to wb35_hw_init()
Date: Wed, 8 Apr 2009 11:14:03 +0300 [thread overview]
Message-ID: <1239178446-12893-8-git-send-email-penberg@cs.helsinki.fi> (raw)
In-Reply-To: <1239178446-12893-1-git-send-email-penberg@cs.helsinki.fi>
Impact: cleanup
The hal_set_phy_type() is called in wb35_hw_init() only so inline the
function there. Also remove a redundant assignment of ->phy_type to
RF_WB_242_1.
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---
drivers/staging/winbond/wbhal.c | 5 -----
drivers/staging/winbond/wbhal_f.h | 1 -
drivers/staging/winbond/wbusb.c | 8 +++-----
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/winbond/wbhal.c b/drivers/staging/winbond/wbhal.c
index 6f1964c..14253f0 100644
--- a/drivers/staging/winbond/wbhal.c
+++ b/drivers/staging/winbond/wbhal.c
@@ -145,11 +145,6 @@ unsigned char hal_idle(struct hw_data * pHwData)
return true;
}
-//---------------------------------------------------------------------------------------------------
-void hal_set_phy_type( struct hw_data * pHwData, u8 PhyType )
-{
- pHwData->phy_type = PhyType;
-}
void hal_set_radio_mode( struct hw_data * pHwData, unsigned char radio_off)
{
diff --git a/drivers/staging/winbond/wbhal_f.h b/drivers/staging/winbond/wbhal_f.h
index d51709f..bdea22f 100644
--- a/drivers/staging/winbond/wbhal_f.h
+++ b/drivers/staging/winbond/wbhal_f.h
@@ -42,7 +42,6 @@ void hal_set_accept_multicast( struct hw_data * pHwData, u8 enable );
void hal_set_accept_beacon( struct hw_data * pHwData, u8 enable );
void hal_stop( struct hw_data * pHwData );
void hal_start_tx0( struct hw_data * pHwData );
-void hal_set_phy_type( struct hw_data * pHwData, u8 PhyType );
#define hal_get_cwmin( _A ) ( (_A)->cwmin )
void hal_set_cwmax( struct hw_data * pHwData, u16 cwin_max );
#define hal_get_cwmax( _A ) ( (_A)->cwmax )
diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c
index fad3b99..742bf7d 100644
--- a/drivers/staging/winbond/wbusb.c
+++ b/drivers/staging/winbond/wbusb.c
@@ -504,7 +504,7 @@ error_reg_destroy:
static int wb35_hw_init(struct ieee80211_hw *hw)
{
struct wbsoft_priv *priv = hw->priv;
- struct hw_data * pHwData;
+ struct hw_data * pHwData = &priv->sHwData;
u8 *pMacAddr;
u8 *pMacAddr2;
u8 EEPROM_region;
@@ -516,18 +516,16 @@ static int wb35_hw_init(struct ieee80211_hw *hw)
priv->sLocalPara.bMacOperationMode = MODE_802_11_BG;
priv->Mds.TxRTSThreshold = DEFAULT_RTSThreshold;
priv->Mds.TxFragmentThreshold = DEFAULT_FRAGMENT_THRESHOLD;
- hal_set_phy_type( &priv->sHwData, RF_WB_242_1 );
priv->sLocalPara.MTUsize = MAX_ETHERNET_PACKET_SIZE;
priv->sLocalPara.bPreambleMode = AUTO_MODE;
priv->sLocalPara.RadioOffStatus.boSwRadioOff = false;
- pHwData = &priv->sHwData;
- hal_set_phy_type( pHwData, RF_DECIDE_BY_INF );
+
+ pHwData->phy_type = RF_DECIDE_BY_INF;
priv->sLocalPara.bWepKeyError= false;
priv->sLocalPara.bToSelfPacketReceived = false;
priv->sLocalPara.WepKeyDetectTimerCount= 2 * 100; /* 2 seconds */
- pHwData = &priv->sHwData;
err = hal_init_hardware(hw);
if (err)
goto error;
--
1.5.6.3
next prev parent reply other threads:[~2009-04-08 8:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 8:13 [PATCH 01/11] w35und: replace switch error handling with gotos in wb35_hw_init() Pekka Enberg
2009-04-08 8:13 ` [PATCH 02/11] w35und: move hal_init_hardware() and hal_halt() int wbusb.c Pekka Enberg
2009-04-08 8:13 ` [PATCH 03/11] w35und: simplify error handling in wb35_hw_init() Pekka Enberg
2009-04-08 8:13 ` [PATCH 04/11] w35und: simplify hal_init_hardware() error handling Pekka Enberg
2009-04-08 8:14 ` [PATCH 05/11] " Pekka Enberg
2009-04-08 8:14 ` [PATCH 06/11] w35und: simplify hal_init_hardware() and hal_halt() Pekka Enberg
2009-04-08 8:14 ` [PATCH 07/11] w35und: clean up comments in wbusb.c Pekka Enberg
2009-04-08 8:14 ` Pekka Enberg [this message]
2009-04-08 8:14 ` [PATCH 09/11] w35und: reformat wbusb.c Pekka Enberg
2009-04-08 8:14 ` [PATCH 10/11] w35und: remove MODULE_AUTHOR Pekka Enberg
2009-04-08 8:14 ` [PATCH 11/11] w35und: make led lookup tables static Pekka Enberg
2009-04-08 10:02 ` Pavel Machek
2009-04-08 9:53 ` [PATCH 01/11] w35und: replace switch error handling with gotos in wb35_hw_init() Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239178446-12893-8-git-send-email-penberg@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®