From: Arnd Bergmann <arnd@arndb.de>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, gnurou@gmail.com
Subject: Re: [PATCH v2 1/2] mmc: sdhci: Set DMA mask
Date: Tue, 01 Mar 2016 22:30:26 +0100 [thread overview]
Message-ID: <12391836.3mgJ3uDMLr@wuerfel> (raw)
In-Reply-To: <1456806764-16467-2-git-send-email-acourbot@nvidia.com>
On Tuesday 01 March 2016 13:32:43 Alexandre Courbot wrote:
> */
> - if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA))) {
> + if (!(host->flags & (SDHCI_USE_SDMA | SDHCI_USE_ADMA)))
> host->dma_mask = DMA_BIT_MASK(64);
> - mmc_dev(mmc)->dma_mask = &host->dma_mask;
> - }
> +
> + if (host->dma_mask &&
> + dma_set_mask_and_coherent(mmc_dev(mmc), host->dma_mask))
> + pr_warn("%s: cannot set DMA mask\n", mmc_hostname(mmc));
>
Looks good,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-03-01 21:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 4:32 [PATCH v2 0/2] mmc: sdhci: Set DMA mask if specified Alexandre Courbot
2016-03-01 4:32 ` [PATCH v2 1/2] mmc: sdhci: Set DMA mask Alexandre Courbot
2016-03-01 21:30 ` Arnd Bergmann [this message]
2016-03-04 6:09 ` Alexandre Courbot
2016-03-01 4:32 ` [PATCH v2 2/2] mmc: sdhci-tegra: Specify valid " Alexandre Courbot
2016-03-01 21:34 ` Arnd Bergmann
2016-03-02 10:36 ` Alexandre Courbot
2016-03-02 11:25 ` Arnd Bergmann
2016-03-04 6:08 ` Alexandre Courbot
2016-03-04 6:43 ` Alexandre Courbot
2016-03-04 8:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12391836.3mgJ3uDMLr@wuerfel \
--to=arnd@arndb.de \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome