mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: David Brownell <david-b@pacbell.net>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: leds: just ignore invalid GPIOs in leds-gpio
Date: Wed, 08 Apr 2009 14:09:45 +0100	[thread overview]
Message-ID: <1239196186.5339.28.camel@dax.rpnet.com> (raw)
In-Reply-To: <200904071751.49507.david-b@pacbell.net>


On Tue, 2009-04-07 at 17:51 -0700, David Brownell wrote:
> On Tuesday 07 April 2009, Geert Uytterhoeven wrote:
> > | drivers/leds/leds-gpio.c:85: warning: 'return' with no value, in function
> > | returning non-void
> > 
> > So what should we return here? -ENODEV? -EINVAL? Anything else?
> 
> Success:  0.  The point is to ignore them, not fail!
> 
> 
> See the appended.

Agreed. I wondered about returning ENODEV and then catching it in the
calling functions but that doesn't work out as very clear code. I'll
queue and submit this.

Cheers,

Richard



      reply	other threads:[~2009-04-08 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904062059.n36Kxlum026774@hera.kernel.org>
2009-04-07 12:00 ` Geert Uytterhoeven
2009-04-08  0:51   ` David Brownell
2009-04-08 13:09     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239196186.5339.28.camel@dax.rpnet.com \
    --to=rpurdie@linux.intel.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®