From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
dwmw2@infradead.org, yinghai@kernel.org, steiner@sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch 11/13] ioapic: Fix non atomic allocation with interrupts disabled
Date: Thu, 09 Apr 2009 20:38:12 +0530 [thread overview]
Message-ID: <1239289692.3296.13.camel@ht.satnam> (raw)
In-Reply-To: <20090317001321.260428000@linux-os.sc.intel.com>
Hello Suresh,
I am getting sparse warning from this patch.
If possible, please run sparse before sending the patches.
On Mon, 2009-03-16 at 17:05 -0700, Suresh Siddha wrote:
> plain text document attachment (fix_kmalloc_with_irqs_disabled.patch)
> save_mask_IO_APIC_setup() was using non atomic memory allocation while getting
> called with interrupts disabled. Fix this by splitting this into two different
> function. Allocation part save_IO_APIC_setup() now happens before
> disabling interrupts.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
> ---
>
> Index: tip/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- tip.orig/arch/x86/kernel/apic/io_apic.c
> +++ tip/arch/x86/kernel/apic/io_apic.c
> @@ -902,6 +895,25 @@ nomem:
> return -ENOMEM;
> }
>
> +void mask_IO_APIC_setup(void)
> +{
> + int apic, pin;
> +
arch/x86/kernel/apic/io_apic.c:806:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
Don't worry you are not alone ;-)
CHECK arch/x86/kernel/apic/io_apic.c
arch/x86/kernel/apic/io_apic.c:544:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:806:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:994:7: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:1012:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:1440:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:1700:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:1994:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
arch/x86/kernel/apic/io_apic.c:2781:6: warning: symbol 'apic' shadows an earlier one
arch/x86/include/asm/apic.h:352:20: originally declared here
Ingo:
don't you think struct apic *apic is very common name can we find some better name.
--
JSR
next prev parent reply other threads:[~2009-04-09 15:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 0:04 [patch 00/13] x2apic and interrupt-remapping related fixes Suresh Siddha
2009-03-17 0:04 ` [patch 01/13] intr-remapping: fix "hard-safe -> hard-unsafe lock order detected" with irq_2_ir_lock Suresh Siddha
2009-03-17 0:04 ` [patch 02/13] dmar: move page fault handling code to dmar.c Suresh Siddha
2009-03-17 0:04 ` [patch 03/13] enable fault handling for intr-remapping Suresh Siddha
2009-03-17 0:04 ` [patch 04/13] dmar: routines for disabling queued invalidation and intr remapping Suresh Siddha
2009-03-17 0:04 ` [patch 05/13] dmar: start with sane state while enabling dma and interrupt-remapping Suresh Siddha
2009-03-17 0:04 ` [patch 06/13] intr-remapping: fix free_irte() to clear all the IRTE entries Suresh Siddha
2009-03-17 0:04 ` [patch 07/13] x2apic: use virtual wire A mode in disable_IO_APIC() with interrupt-remapping Suresh Siddha
2009-03-17 0:05 ` [patch 08/13] x86: fix clear_local_APIC() in the presence of x2apic Suresh Siddha
2009-03-17 0:05 ` [patch 09/13] x86: cleanup the IO-APIC level migration with interrupt-remapping Suresh Siddha
2009-03-17 0:05 ` [patch 10/13] cleanup ifdef CONFIG_INTR_REMAP in io_apic code Suresh Siddha
2009-03-17 0:05 ` [patch 11/13] ioapic: Fix non atomic allocation with interrupts disabled Suresh Siddha
2009-04-09 15:08 ` Jaswinder Singh Rajput [this message]
2009-03-17 0:05 ` [patch 12/13] x86: fix broken irq migration logic while cleaning up multiple vectors Suresh Siddha
2009-03-17 0:05 ` [patch 13/13] dmar: use atomic allocations for QI and Intr-remapping init Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239289692.3296.13.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome