From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LTP <ltp-list@lists.sourceforge.net>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 2/2] lockdep: choose to continue lock debugging despite taint
Date: Thu, 9 Apr 2009 23:27:40 +0200 [thread overview]
Message-ID: <1239312460-13396-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1239312460-13396-1-git-send-email-fweisbec@gmail.com>
Lockdep is disabled after any kernel taints. This might be convenient
to ignore bad locking issues which sources come from outside the kernel
tree. Nevertheless, it might be a frustrating experience for the
staging developers or anyone who might develop a kernel that happens
to be tainted.
Just provide an option to let one choose to continue lock-debugging
after any taint.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
diff --git a/kernel/panic.c b/kernel/panic.c
index 9e7420a..eadc0b5 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -213,6 +213,7 @@ unsigned long get_taint(void)
void add_taint(unsigned flag)
{
+#ifndef CONFIG_LOCKDEP_IGNORE_TAINT
/*
* Can't trust the integrity of the kernel anymore.
* We don't call directly debug_locks_off() because the issue
@@ -220,6 +221,7 @@ void add_taint(unsigned flag)
*/
if (xchg(&debug_locks, 0))
printk(KERN_WARNING "Disabling lockdep due to kernel taint\n");
+#endif
set_bit(flag, &tainted_mask);
}
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c6e854f..599888b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -436,6 +436,20 @@ config PROVE_LOCKING
For more details, see Documentation/lockdep-design.txt.
+config LOCKDEP_IGNORE_TAINT
+ bool "Lock debugging: continue despite taints"
+ depends on LOCKDEP
+ default n
+ help
+ If your kernel becomes tainted because of a warning,
+ a staging or proprietary module loaded, etc... lockdep
+ will be disabled by default. Select this option if you
+ want lockdep to continue running despite a taint. If
+ you are working on a staging driver, experiencing
+ warnings but focusing on something else, or whatever
+ reason that makes you developing on a kernel that is
+ tainted, you might want to say Y here.
+
config LOCKDEP
bool
depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
--
1.6.1
next prev parent reply other threads:[~2009-04-09 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 21:27 [PATCH 1/2] lockdep: warn about lockdep disabling after kernel taint Frederic Weisbecker
2009-04-09 21:27 ` Frederic Weisbecker [this message]
2009-04-10 12:15 ` [PATCH 2/2] lockdep: choose to continue lock debugging despite taint Ingo Molnar
2009-04-10 13:38 ` Frederic Weisbecker
2009-04-10 13:45 ` Ingo Molnar
2009-04-11 1:15 ` Frederic Weisbecker
2009-04-11 1:37 ` Frederic Weisbecker
2009-04-12 14:09 ` Ingo Molnar
2009-04-11 1:17 ` [PATCH 1/2 v2] lockdep: warn about lockdep disabling after kernel taint Frederic Weisbecker
2009-04-12 14:45 ` [tip:core/urgent] " Frederic Weisbecker
2009-04-11 1:17 ` [PATCH 2/2 v2] lockdep: continue lock debugging despite some taints Frederic Weisbecker
2009-04-12 14:45 ` [tip:core/urgent] " Frederic Weisbecker
2009-04-10 12:12 ` [PATCH 1/2] lockdep: warn about lockdep disabling after kernel taint Ingo Molnar
2009-04-10 13:34 ` Frederic Weisbecker
2009-04-10 13:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239312460-13396-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltp-list@lists.sourceforge.net \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome