mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Jan Kara <jack@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: [PATCH 0/2] ext3 data=guarded
Date: Tue, 14 Apr 2009 16:57:13 -0400	[thread overview]
Message-ID: <1239742633.28321.39.camel@think.oraclecorp.com> (raw)

Hello everyone,

Here is the ext3 data=guarded code again, this time it has passed some
basic tests.  It should safely leave non data=guarded mounts alone and
only be dangerous when the new code is turned on (I hope).

On the performance side, it runs the same as data=writeback, except when
you're making files with holes where it runs the same as data=ordered.

There's definitely more CPU time involved with tracking the data=guarded
buffer heads and updating i_size when the IO is over, but at least on my
5 drive array that doesn't show up.

For the fsync + background streaming write workload, data=guarded does
fsync's in 0.8s, just like data=writeback.  data=ordered on the same
test was doing between 5 and 30s per fsync, so it seems I've fixed that
part at least.

The next step is much more testing (blocksize != pagesize among others)
and much more review.  But, I'm hoping for some feedback first on if
this is a direction we want to take the ext3 code.

The diffstat looks scary, but lots of the changes are comments...

-chris



             reply	other threads:[~2009-04-14 20:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14 20:57 Chris Mason [this message]
2009-04-14 20:59 ` [PATCH 1/2] Add block_write_full_page_endio for passing endio handler Chris Mason
2009-04-14 21:00 ` [PATCH 2/2] ext3: add data=guarded mode Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239742633.28321.39.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®