mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Nizette <bn@niasdigital.com>
To: tglx@linutronix.de
Cc: David Brownell <david-b@pacbell.net>,
	hskinnemoen@atmel.com, kernel@avr32linux.org,
	linux-kernel@vger.kernel.org, imre.deak@nokia.com, mingo@elte.hu
Subject: Re: [REGRESSION] threaded interrupt handler support breaks (some) irq handling on AVR32
Date: Wed, 15 Apr 2009 11:30:53 +1000	[thread overview]
Message-ID: <1239759053.29831.37.camel@linux-51e8.site> (raw)
In-Reply-To: <1239698225.29831.14.camel@linux-51e8.site>

On Tue, 2009-04-14 at 18:37 +1000, Ben Nizette wrote:

> If no one beats me to it i'll try and scatter printks and narrow down
> exactly *where* it all explodes tomorrow.

static irqreturn_t ads7846_irq(int irq, void *handle)
{
	struct ads7846 *ts = handle;
	unsigned long flags;

	spin_lock_irqsave(&ts->lock, flags);
	if (likely(get_pendown_state(ts))) {
		if (!ts->irq_disabled) {
			/* The ARM do_simple_IRQ() dispatcher doesn't act
			 * like the other dispatchers:  it will report IRQs
			 * even after they've been disabled.  We work around
			 * that here.  (The "generic irq" framework may help...)
			 */
			ts->irq_disabled = 1;
			disable_irq(ts->spi->irq);
			ts->pending = 1;
			hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY),
					HRTIMER_MODE_REL);
		}
	}
	spin_unlock_irqrestore(&ts->lock, flags);

	return IRQ_HANDLED;
}

Right, a scattering of printks in there shows execution gets at least as
far as inside the inner-most code block.  A printk directly before the
disable_irq() doesn't make it to my console so I'm guessing that the
hang is in there somewhere.

Hope this helps,
	--Ben.




  reply	other threads:[~2009-04-15  1:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1239685153.19815.12.camel@linux-51e8.site>
2009-04-14  8:37 ` Ben Nizette
2009-04-15  1:30   ` Ben Nizette [this message]
2009-04-15  7:57     ` Haavard Skinnemoen
2009-04-15  8:33       ` Haavard Skinnemoen
2009-04-15 16:01         ` Bill Gatliff
2009-04-16  8:40           ` Haavard Skinnemoen
2009-04-16 13:25             ` Bill Gatliff
2009-04-16  0:41       ` [PATCH] ads7846: fix unsafe disable_irq (was [REGRESSION] threaded interrupt handler support breaks (some) irq handling on AVR32) Ben Nizette
2009-04-16  1:58         ` Dmitry Torokhov
2009-04-14  5:46 [REGRESSION] threaded interrupt handler support breaks (some) irq handling on AVR32 Ben Nizette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239759053.29831.37.camel@linux-51e8.site \
    --to=bn@niasdigital.com \
    --cc=david-b@pacbell.net \
    --cc=hskinnemoen@atmel.com \
    --cc=imre.deak@nokia.com \
    --cc=kernel@avr32linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome