mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>
Cc: Zhaolei <zhaolei@cn.fujitsu.com>,
	Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 2/2 v3] tracing/lock: provide lock_acquired event support for dynamic size string
Date: Sun, 19 Apr 2009 07:01:35 +0200	[thread overview]
Message-ID: <1240117295-6873-3-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1240117295-6873-1-git-send-email-fweisbec@gmail.com>

Now that we can support the dynamic sized string, make the lock tracing
able to use it, making it safe against modules removal and consuming
the right amount of memory needed for each lock name

Changes in v2:
adapt to the __ending_string() updates and the opening_string() removal.

[ Impact: protect against module removal ]

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
 include/trace/events/lockdep.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/trace/events/lockdep.h b/include/trace/events/lockdep.h
index 45e326b..3ca315c 100644
--- a/include/trace/events/lockdep.h
+++ b/include/trace/events/lockdep.h
@@ -38,16 +38,16 @@ TRACE_EVENT(lock_acquired,
 	TP_ARGS(lock, ip, waittime),
 
 	TP_STRUCT__entry(
-		__field(const char *, name)
+		__string(name, lock->name)
 		__field(unsigned long, wait_usec)
 		__field(unsigned long, wait_nsec_rem)
 	),
 	TP_fast_assign(
-		__entry->name = lock->name;
+		__assign_str(name, lock->name);
 		__entry->wait_nsec_rem = do_div(waittime, NSEC_PER_USEC);
 		__entry->wait_usec = (unsigned long) waittime;
 	),
-	TP_printk("%s (%lu.%03lu us)", __entry->name, __entry->wait_usec,
+	TP_printk("%s (%lu.%03lu us)", __get_str(name), __entry->wait_usec,
 				       __entry->wait_nsec_rem)
 );
 
-- 
1.6.1


  parent reply	other threads:[~2009-04-19  5:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-19  5:01 [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Frederic Weisbecker
2009-04-19  5:01 ` [PATCH 1/2 v3] tracing/events: provide string with undefined size support Frederic Weisbecker
2009-04-19  6:15   ` Li Zefan
2009-04-19 12:35     ` Frederic Weisbecker
2009-04-21 18:16   ` Frederic Weisbecker
2009-04-21 18:33     ` Steven Rostedt
2009-04-21 21:58   ` Steven Rostedt
2009-04-21 22:00     ` Steven Rostedt
2009-04-21 22:12       ` Frederic Weisbecker
2009-04-21 22:21         ` Steven Rostedt
2009-04-21 23:32           ` [PATCH][GIT-PULL] tracing/events: protect __get_str() Frederic Weisbecker
2009-04-22 10:25             ` Ingo Molnar
2009-04-22 10:41           ` [PATCH 1/2 v3] tracing/events: provide string with undefined size support Ingo Molnar
2009-04-19  5:01 ` Frederic Weisbecker [this message]
2009-04-21 21:59   ` [PATCH 2/2 v3] tracing/lock: provide lock_acquired event support for dynamic size string Steven Rostedt
2009-04-19  6:14 ` [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Li Zefan
2009-04-19 12:34   ` Frederic Weisbecker
2009-04-19 13:49     ` [PATCH] tracing/core: Add current context on tracing recursion warning Frederic Weisbecker
2009-04-19 14:01       ` Ingo Molnar
2009-04-19 14:22         ` Frederic Weisbecker
2009-04-19 18:45           ` Ingo Molnar
2009-04-19 18:48             ` Frédéric Weisbecker
2009-04-19 18:47           ` Ingo Molnar
2009-04-19 17:28       ` Frederic Weisbecker
2009-04-20  0:37         ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240117295-6873-3-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    --cc=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome