mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: linux-kernel@vger.kernel.org
Cc: linux-input@vger.kernel.org, gregkh@suse.de,
	kay.sievers@vrfy.org,
	Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: [PATCH 0/4] fix some improper uses of dev_set_name
Date: Mon, 20 Apr 2009 21:17:12 -0300	[thread overview]
Message-ID: <1240273036-5995-1-git-send-email-cascardo@holoscopio.com> (raw)

dev_set_name expects a format string. Many of its uses, however, blindly
call it with a string variable that comes from some external, perhaps
unreliable source. Some of those uses are safe, like those in the third
patch in the series and most of those not fixed by any of them. Some few
remaining uses may require some more attention to decide if a patch is
really required. Perhaps converting all of them for safeness is a good
compromise.

Thadeu Lima de Souza Cascardo (4):
  driver core: use string format when name is another device's name
  driver core: use string format when name is given to an exported
    function
  input: set the device's name and copy it to private version
  ARM: use put_device instead of kfree

 arch/arm/common/sa1111.c            |    3 +--
 arch/microblaze/kernel/of_device.c  |    2 +-
 arch/powerpc/kernel/of_device.c     |    2 +-
 drivers/base/attribute_container.c  |    2 +-
 drivers/base/core.c                 |    4 ++--
 drivers/base/firmware_class.c       |    2 +-
 drivers/base/platform.c             |    2 +-
 drivers/ide/ide-cd.c                |    2 +-
 drivers/ide/ide-gd.c                |    2 +-
 drivers/ide/ide-tape.c              |    2 +-
 drivers/input/evdev.c               |    4 ++--
 drivers/input/joydev.c              |    4 ++--
 drivers/input/mousedev.c            |    8 ++++----
 drivers/isdn/mISDN/dsp_pipeline.c   |    2 +-
 drivers/misc/enclosure.c            |    4 ++--
 drivers/scsi/sd.c                   |    2 +-
 drivers/video/backlight/backlight.c |    2 +-
 drivers/video/backlight/lcd.c       |    2 +-
 drivers/video/output.c              |    2 +-
 fs/partitions/check.c               |    2 +-
 20 files changed, 27 insertions(+), 28 deletions(-)


             reply	other threads:[~2009-04-21  1:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21  0:17 Thadeu Lima de Souza Cascardo [this message]
     [not found] ` <cover.1240272928.git.cascardo@holoscopio.com>
2009-04-21  0:17   ` [PATCH 1/4] driver core: use string format when name is another device's name Thadeu Lima de Souza Cascardo
2009-04-21  0:17   ` [PATCH 2/4] driver core: use string format when name is given to an exported function Thadeu Lima de Souza Cascardo
2009-04-21  0:17   ` [PATCH 3/4] input: set the device's name and copy it to private version Thadeu Lima de Souza Cascardo
2009-04-21  0:17   ` [PATCH 4/4] ARM: use put_device instead of kfree Thadeu Lima de Souza Cascardo
2009-04-22  5:45 ` [PATCH 0/4] fix some improper uses of dev_set_name Greg KH
2009-04-22 21:06   ` Thadeu Lima de Souza Cascardo
2009-05-11  1:09     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240273036-5995-1-git-send-email-cascardo@holoscopio.com \
    --to=cascardo@holoscopio.com \
    --cc=gregkh@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®