From: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
To: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net
Cc: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
Subject: [PATCH 1/1] TWL4030: Activate VDD1, VDD2 and VPLL1 at startup
Date: Thu, 23 Apr 2009 16:10:08 +0300 [thread overview]
Message-ID: <1240492208-14791-2-git-send-email-peter.de-schrijver@nokia.com> (raw)
In-Reply-To: <1240492208-14791-1-git-send-email-peter.de-schrijver@nokia.com>
This patch activates VDD1, VDD2 and VPLL1 when booting. This is necessary
because these resources are in warm reset state after a reboot. This means
their voltage levels cannot be modified so DVFS and smartreflex don't work.
Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
---
drivers/regulator/twl4030-regulator.c | 18 +++++++++++++++++-
1 files changed, 17 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
index 80a4e10..ab2a726 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -506,6 +506,22 @@ static int twl4030reg_probe(struct platform_device *pdev)
}
platform_set_drvdata(pdev, rdev);
+ /* VDD1, VDD2 and VPLL1 are left in warm reset state after a reboot.
+ * We need to put them back to active state for DVFS and smartreflex.
+ */
+
+ if (twl4030_send_pb_msg(MSG_SINGULAR(DEV_GRP_P1, RES_VDD1,
+ RES_STATE_ACTIVE)) < 0)
+ pr_err("Unable to activate VDD1\n");
+
+ if (twl4030_send_pb_msg(MSG_SINGULAR(DEV_GRP_P1, RES_VDD2,
+ RES_STATE_ACTIVE)) < 0)
+ pr_err("Unable to activate VDD2\n");
+
+ if (twl4030_send_pb_msg(MSG_SINGULAR(DEV_GRP_P1, RES_VPLL1,
+ RES_STATE_ACTIVE)) < 0)
+ pr_err("Unable to activate VPLL1\n");
+
/* NOTE: many regulators support short-circuit IRQs (presentable
* as REGULATOR_OVER_CURRENT notifications?) configured via:
* - SC_CONFIG
--
1.5.6.3
next prev parent reply other threads:[~2009-04-23 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 13:10 [PATCH 0/1] *** SUBJECT HERE *** Peter 'p2' De Schrijver
2009-04-23 13:10 ` Peter 'p2' De Schrijver [this message]
2009-04-23 14:57 ` [PATCH 1/1] TWL4030: Activate VDD1, VDD2 and VPLL1 at startup Mark Brown
2009-04-23 21:53 ` David Brownell
2009-04-24 10:57 ` Peter 'p2' De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240492208-14791-2-git-send-email-peter.de-schrijver@nokia.com \
--to=peter.de-schrijver@nokia.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®