From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] HPET: stop soliciting hpet=force users on ICH4M
Date: Thu, 23 Apr 2009 16:19:04 -0700 [thread overview]
Message-ID: <1240528744.4529.9153.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0904231918510.15843@localhost.localdomain>
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
On Thu, 2009-04-23 at 16:19 -0700, Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
>
> The HPET in the ICH4M is not documented in the data sheet
> because it was not officially validated.
>
> While it is fine for hackers to continue to use "hpet=force"
> to enable the hardware that they have, it is not prudent to
> solicit additional "hpet=force" users on this hardware.
>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> arch/x86/kernel/quirks.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
> index e95022e..7563b31 100644
> --- a/arch/x86/kernel/quirks.c
> +++ b/arch/x86/kernel/quirks.c
> @@ -261,8 +261,6 @@ static void old_ich_force_enable_hpet_user(struct pci_dev *dev)
> {
> if (hpet_force_user)
> old_ich_force_enable_hpet(dev);
> - else
> - hpet_print_force_info();
> }
>
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB_1,
next prev parent reply other threads:[~2009-04-23 23:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 2:27 [PATCH] x86/hpet: prevent boot hang when hpet=force used on old ICH Len Brown
2009-04-23 6:09 ` Ingo Molnar
2009-04-23 23:05 ` Len Brown
2009-04-24 23:45 ` Ingo Molnar
2009-04-23 23:18 ` [PATCH] ACPI/hpet: prevent boot hang when hpet=force used on ICH-4M Len Brown
2009-04-23 23:18 ` Pallipadi, Venkatesh
2009-04-23 23:19 ` [PATCH] HPET: stop soliciting hpet=force users on ICH4M Len Brown
2009-04-23 23:19 ` Pallipadi, Venkatesh [this message]
2009-04-24 6:43 ` Ingo Molnar
2009-04-24 6:45 ` [tip:x86/urgent] x86, hpet: Stop " tip-bot for Len Brown
2009-04-24 6:37 ` [PATCH] ACPI/hpet: prevent boot hang when hpet=force used on ICH-4M Ingo Molnar
2009-04-24 14:49 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240528744.4529.9153.camel@localhost.localdomain \
--to=venkatesh.pallipadi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®