mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: Support list_voltage for fixed voltage regulator
Date: Tue, 28 Apr 2009 14:24:13 +0100	[thread overview]
Message-ID: <1240925053.14165.145.camel@vega.slimlogic.co.uk> (raw)
In-Reply-To: <1240913635-22404-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Tue, 2009-04-28 at 11:13 +0100, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  drivers/regulator/fixed.c |   15 ++++++++++++++-
>  1 files changed, 14 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
> index 6e0bede..4c525af 100644
> --- a/drivers/regulator/fixed.c
> +++ b/drivers/regulator/fixed.c
> @@ -44,10 +44,22 @@ static int fixed_voltage_get_voltage(struct regulator_dev *dev)
>  	return data->microvolts;
>  }
>  
> +static int fixed_voltage_list_voltage(struct regulator_dev *dev,
> +				      unsigned selector)
> +{
> +	struct fixed_voltage_data *data = rdev_get_drvdata(dev);
> +
> +	if (selector != 0)
> +		return -EINVAL;
> +
> +	return data->microvolts;
> +}
> +
>  static struct regulator_ops fixed_voltage_ops = {
>  	.is_enabled = fixed_voltage_is_enabled,
>  	.enable = fixed_voltage_enable,
>  	.get_voltage = fixed_voltage_get_voltage,
> +	.list_voltage = fixed_voltage_list_voltage,
>  };
>  
>  static int regulator_fixed_voltage_probe(struct platform_device *pdev)
> @@ -69,7 +81,8 @@ static int regulator_fixed_voltage_probe(struct platform_device *pdev)
>  	}
>  	drvdata->desc.type = REGULATOR_VOLTAGE;
>  	drvdata->desc.owner = THIS_MODULE;
> -	drvdata->desc.ops = &fixed_voltage_ops,
> +	drvdata->desc.ops = &fixed_voltage_ops;
> +	drvdata->desc.n_voltages = 1;
>  
>  	drvdata->microvolts = config->microvolts;
>  

Applied.

Thanks

Liam


      parent reply	other threads:[~2009-04-28 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 10:13 Mark Brown
2009-04-28 10:13 ` [PATCH 2/2] regulator: Set MODULE_ALIAS for regulator drivers Mark Brown
2009-04-28 13:24   ` Liam Girdwood
2009-04-28 13:24 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240925053.14165.145.camel@vega.slimlogic.co.uk \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®