From: Tim Abbott <tabbott@MIT.EDU>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Anders Kaseorg <andersk@MIT.EDU>, Waseem Daher <wdaher@MIT.EDU>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jeff Arnold <jbarnold@MIT.EDU>, Paul Mundt <lethal@linux-sh.org>,
David Howells <dhowells@redhat.com>, Tim Abbott <tabbott@MIT.EDU>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH v2 15/15] x86: Use macros for .data.page_aligned.
Date: Tue, 28 Apr 2009 13:01:02 -0400 [thread overview]
Message-ID: <1240938062-3264-16-git-send-email-tabbott@mit.edu> (raw)
In-Reply-To: <1240938062-3264-15-git-send-email-tabbott@mit.edu>
.data.page_aligned should not need a separate output section. So, as
part of this cleanup I moved it into the .data output section in the
linker scripts in order to eliminate unnecessary references to the
section name.
Signed-off-by: Tim Abbott <tabbott@mit.edu>
Cc: Ingo Molnar <mingo@redhat.com>
---
arch/x86/kernel/head_32.S | 2 +-
arch/x86/kernel/vmlinux_32.lds.S | 6 +-----
arch/x86/kernel/vmlinux_64.lds.S | 6 +-----
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel/head_32.S b/arch/x86/kernel/head_32.S
index 8f2a18b..f2a44f3 100644
--- a/arch/x86/kernel/head_32.S
+++ b/arch/x86/kernel/head_32.S
@@ -636,7 +636,7 @@ ENTRY(empty_zero_page)
* This starts the data section.
*/
#ifdef CONFIG_X86_PAE
-.section ".data.page_aligned","wa"
+__PAGE_ALIGNED_DATA
/* Page-aligned for the benefit of paravirt? */
.align PAGE_SIZE_asm
ENTRY(swapper_pg_dir)
diff --git a/arch/x86/kernel/vmlinux_32.lds.S b/arch/x86/kernel/vmlinux_32.lds.S
index fdb0642..57cbcf2 100644
--- a/arch/x86/kernel/vmlinux_32.lds.S
+++ b/arch/x86/kernel/vmlinux_32.lds.S
@@ -64,6 +64,7 @@ SECTIONS
/* writeable */
. = ALIGN(PAGE_SIZE);
.data : AT(ADDR(.data) - LOAD_OFFSET) { /* Data */
+ PAGE_ALIGNED_DATA
DATA_DATA
CONSTRUCTORS
} :data
@@ -76,11 +77,6 @@ SECTIONS
__nosave_end = .;
}
- . = ALIGN(PAGE_SIZE);
- .data.page_aligned : AT(ADDR(.data.page_aligned) - LOAD_OFFSET) {
- *(.data.page_aligned)
- }
-
. = ALIGN(32);
.data.cacheline_aligned : AT(ADDR(.data.cacheline_aligned) - LOAD_OFFSET) {
*(.data.cacheline_aligned)
diff --git a/arch/x86/kernel/vmlinux_64.lds.S b/arch/x86/kernel/vmlinux_64.lds.S
index 424fb87..5b74dc9 100644
--- a/arch/x86/kernel/vmlinux_64.lds.S
+++ b/arch/x86/kernel/vmlinux_64.lds.S
@@ -64,6 +64,7 @@ SECTIONS
. = ALIGN(PAGE_SIZE);
/* Data */
.data : AT(ADDR(.data) - LOAD_OFFSET) {
+ PAGE_ALIGNED_DATA
DATA_DATA
CONSTRUCTORS
/* End of data section */
@@ -157,11 +158,6 @@ SECTIONS
*(.data.init_task)
} :data.init
- .data.page_aligned : AT(ADDR(.data.page_aligned) - LOAD_OFFSET) {
- . = ALIGN(PAGE_SIZE);
- *(.data.page_aligned)
- }
-
.smp_locks : AT(ADDR(.smp_locks) - LOAD_OFFSET) {
/* might get freed after init */
. = ALIGN(PAGE_SIZE);
--
1.6.2.1
next prev parent reply other threads:[~2009-04-28 17:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 17:00 [PATCH v2 00/15] clean up page aligned data and bss sections Tim Abbott
2009-04-28 17:00 ` [PATCH v2 01/15] Add new macros for page-aligned " Tim Abbott
2009-04-28 17:00 ` [PATCH v2 02/15] sh: Use macros for .bss.page_aligned section Tim Abbott
2009-04-28 17:00 ` [PATCH v2 03/15] mn10300: " Tim Abbott
2009-04-28 17:00 ` [PATCH v2 04/15] xtensa: " Tim Abbott
2009-04-28 17:00 ` [PATCH v2 05/15] x86: " Tim Abbott
2009-04-28 17:00 ` [PATCH v2 06/15] alpha: Use macros for .data.page_aligned Tim Abbott
2009-04-28 17:00 ` [PATCH v2 07/15] avr32: Use standard macros for .data.page_aligned section Tim Abbott
2009-04-28 17:00 ` [PATCH v2 08/15] sh: Use " Tim Abbott
2009-04-28 17:00 ` [PATCH v2 09/15] s390: Use macros for .data.page_aligned Tim Abbott
2009-04-28 17:00 ` [PATCH v2 10/15] powerpc: Remove unused __page_aligned macro Tim Abbott
2009-04-28 17:00 ` [PATCH v2 11/15] powerpc: share .data output section definition between 32 and 64 bits Tim Abbott
2009-04-28 17:00 ` [PATCH v2 12/15] powerpc: Use macros for .data.page_aligned section Tim Abbott
2009-04-28 17:01 ` [PATCH v2 13/15] mn10300: Drop unused .data.idt section Tim Abbott
2009-04-28 17:01 ` [PATCH v2 14/15] x86: Use section .data.page_aligned for the idt_table Tim Abbott
2009-04-28 17:01 ` Tim Abbott [this message]
2009-04-28 21:27 ` [PATCH v2 13/15] mn10300: Drop unused .data.idt section David Howells
2009-04-28 22:52 ` [PATCH v2 12/15] powerpc: Use macros for .data.page_aligned section Paul Mackerras
2009-04-28 21:27 ` [PATCH v2 03/15] mn10300: Use macros for .bss.page_aligned section David Howells
2009-04-28 19:48 ` [PATCH v2 00/15] clean up page aligned data and bss sections Tim Abbott
2009-04-29 20:50 ` Sam Ravnborg
2009-04-28 21:27 ` [PATCH v2 01/15] Add new macros for page-aligned " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240938062-3264-16-git-send-email-tabbott@mit.edu \
--to=tabbott@mit.edu \
--cc=andersk@MIT.EDU \
--cc=dhowells@redhat.com \
--cc=jbarnold@MIT.EDU \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
--cc=wdaher@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®