mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zbr@ioremap.net
To: David Fries <david@fries.net>,
	Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>
Subject: Re: [PATCH v2] w1: do not unlock unheld list_mutex in __w1_remove_master_device()
Date: Wed, 07 May 2014 03:51:06 +0400	[thread overview]
Message-ID: <1240941399420266@web11m.yandex.ru> (raw)
In-Reply-To: <20140506234930.GU21508@spacedout.fries.net>

Hi everyone

07.05.2014, 03:49, "David Fries" <David@Fries.net>:
> Acked-by: David Fries <david@fries.net>
>
> On Wed, May 07, 2014 at 01:26:04AM +0400, Alexey Khoroshilov wrote:
>
>>  w1_process_callbacks() expects to be called with dev->list_mutex held,
>>  but it is the fact only in w1_process(). __w1_remove_master_device()
>>  calls w1_process_callbacks() after it releases list_mutex.
>>
>>  The patch fixes __w1_remove_master_device() to acquire list_mutex
>>  for w1_process_callbacks().
>>
>>  Found by Linux Driver Verification project (linuxtesting.org).
>>
>>  Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Thanks for this fix
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

  reply	other threads:[~2014-05-06 23:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 20:37 [PATCH] " Alexey Khoroshilov
2014-04-30 20:45 ` Alexey Khoroshilov
2014-05-01  3:48 ` David Fries
2014-05-06 21:26   ` [PATCH v2] " Alexey Khoroshilov
2014-05-06 23:49     ` David Fries
2014-05-06 23:51       ` zbr [this message]
2014-05-06 21:42   ` [PATCH] " Alexey Khoroshilov
2014-05-06 23:49     ` David Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240941399420266@web11m.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=david@fries.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®