mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ed Swierk <eswierk@aristanetworks.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] x86: x86_32 kdump boot on cpu != 0
Date: Wed, 29 Apr 2009 14:56:12 -0700	[thread overview]
Message-ID: <1241042172.13036.9.camel@localhost.localdomain> (raw)

Booting an x86_32 SMP kernel via kdump fails if the boot CPU has local
APIC ID != 0, with a panic:

  Boot APIC ID in local APIC unexpected (1 vs 0)

MP_processor_info() sets boot_cpu_physical_apicid to 0 based on the
mptable.  But this variable needs to be set to 1 later on to reflect the
actual local APIC ID.  (Setting it to 1 right off the bat causes
generic_processor_info() to complain about an "apic version mismatch",
which I don't understand.)

This change restores the apic_64.c logic, which existed prior to the
merge with apic_32.c, and allows the kdump kernel to boot.
 
Signed-off-by: Ed Swierk <eswierk@aristanetworks.com>
---
 arch/x86/kernel/apic/apic.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index f287092..b45c764 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1563,8 +1563,7 @@ void __init init_apic_mappings(void)
 	 * Fetch the APIC ID of the BSP in case we have a
 	 * default configuration (or the MP table is broken).
 	 */
-	if (boot_cpu_physical_apicid == -1U)
-		boot_cpu_physical_apicid = read_apic_id();
+	boot_cpu_physical_apicid = read_apic_id();
 }
 
 /*



                 reply	other threads:[~2009-04-29 21:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241042172.13036.9.camel@localhost.localdomain \
    --to=eswierk@aristanetworks.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®