From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760053AbZEFNz2 (ORCPT ); Wed, 6 May 2009 09:55:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756360AbZEFNzS (ORCPT ); Wed, 6 May 2009 09:55:18 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39156 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910AbZEFNzQ (ORCPT ); Wed, 6 May 2009 09:55:16 -0400 Subject: Re: [PATCH, RFC] sputrace: use the generic event tracer From: Steven Rostedt To: Ingo Molnar Cc: Christoph Hellwig , Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras , cbe-oss-dev@ozlabs.org, linux-kernel@vger.kernel.org, Fr?d?ric Weisbecker In-Reply-To: <20090506112301.GK25203@elte.hu> References: <20090506102918.GA23278@lst.de> <20090506105748.GE25203@elte.hu> <20090506110258.GA24850@lst.de> <20090506112301.GK25203@elte.hu> Content-Type: text/plain Organization: Red Hat Date: Wed, 06 May 2009 09:54:49 -0400 Message-Id: <1241618089.11379.22.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-05-06 at 13:23 +0200, Ingo Molnar wrote: > > > > +# magic for the trace events > > > > +CFLAGS_sched.o := -I$(src) > > > > > > Steve, i'm wondering whether this type of Makefile hackery (caused > > > by modular tracepoints) could be eliminated ... > > > > We would just have to include the header file with "" instead of > > <>. But I remember Steve not liking this when we talked about it. > > Yeah. But changing Makefiles isnt particularly clean either ... > > And adding -I$(src) can have side-effects: we often have a local > foo.h while an include/linux/foo.h as well. That still would not conflict, because #include "foo.h" will not include "linux/foo.h" and #include will not include a local foo.h, unless there's also a local "linux" directory with a foo.h in it. The Makefile hack has to do with being able to have the "foo.h" file with the TRACE_EVENTs someplace other than include/trace. If the "foo.h" is in include/trace.h we do not need to include this hack. But because the include/trace/define_trace.h needs to include the "foo.h" file recursively, it must be able to find it. If we do not add a search path, include/trace/define_trace.h will not look in the other locations. Note, as Christoph did, we only need to add the include path to the file that defines "CREATE_TRACE_POINTS". Which is only one file. CFLAGS_sched.o := -I$(src) Only touches the sched.c file in that directory (Note, for those reading this thread out of context, this is not the same file as kernel/sched.c) -- Steve