mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: cbe-oss-dev@ozlabs.org, linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net,
	Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Subject: [PATCH 12/15] ps3fb: Tear down FB setup during cleanup
Date: Fri,  8 May 2009 16:01:21 +0200	[thread overview]
Message-ID: <1241791284-11490-13-git-send-email-Geert.Uytterhoeven@sonycom.com> (raw)
In-Reply-To: <1241791284-11490-12-git-send-email-Geert.Uytterhoeven@sonycom.com>

During cleanup, use L1GPU_CONTEXT_ATTRIBUTE_FB_CLOSE to tear down the setup
done by L1GPU_CONTEXT_ATTRIBUTE_FB_SETUP.

This allows unloading and reloading of ps3fb while the sound driver keeps the
GPU open.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
---
 arch/powerpc/include/asm/ps3gpu.h |    8 ++++++++
 drivers/video/ps3fb.c             |    5 ++++-
 2 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/ps3gpu.h b/arch/powerpc/include/asm/ps3gpu.h
index 1037efa..b2b8959 100644
--- a/arch/powerpc/include/asm/ps3gpu.h
+++ b/arch/powerpc/include/asm/ps3gpu.h
@@ -31,6 +31,7 @@
 #define L1GPU_CONTEXT_ATTRIBUTE_FB_SETUP	0x600
 #define L1GPU_CONTEXT_ATTRIBUTE_FB_BLIT		0x601
 #define L1GPU_CONTEXT_ATTRIBUTE_FB_BLIT_SYNC	0x602
+#define L1GPU_CONTEXT_ATTRIBUTE_FB_CLOSE	0x603
 
 #define L1GPU_FB_BLIT_WAIT_FOR_COMPLETION	(1ULL << 32)
 
@@ -75,4 +76,11 @@ static inline int lv1_gpu_fb_blit(u64 context_handle, u64 ddr_offset,
 					 pitch);
 }
 
+static inline int lv1_gpu_fb_close(u64 context_handle)
+{
+	return lv1_gpu_context_attribute(context_handle,
+					 L1GPU_CONTEXT_ATTRIBUTE_FB_CLOSE, 0,
+					 0, 0, 0);
+}
+
 #endif /* _ASM_POWERPC_PS3GPU_H */
diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c
index 3bbdc9d..aa3ebe4 100644
--- a/drivers/video/ps3fb.c
+++ b/drivers/video/ps3fb.c
@@ -1122,7 +1122,7 @@ static int __devinit ps3fb_probe(struct ps3_system_bus_device *dev)
 
 	info = framebuffer_alloc(sizeof(struct ps3fb_par), &dev->core);
 	if (!info)
-		goto err_context_unmap;
+		goto err_context_fb_close;
 
 	par = info->par;
 	par->mode_id = ~ps3fb_mode;	/* != ps3fb_mode, to trigger change */
@@ -1187,6 +1187,8 @@ err_fb_dealloc:
 	fb_dealloc_cmap(&info->cmap);
 err_framebuffer_release:
 	framebuffer_release(info);
+err_context_fb_close:
+	lv1_gpu_fb_close(ps3fb.context_handle);
 err_context_unmap:
 	lv1_gpu_context_iomap(ps3fb.context_handle, GPU_IOIF, xdr_lpar,
 			      ps3fb_videomemory.size, IOPTE_M);
@@ -1232,6 +1234,7 @@ static int ps3fb_shutdown(struct ps3_system_bus_device *dev)
 		info = dev->core.driver_data = NULL;
 	}
 	iounmap((u8 __force __iomem *)ps3fb.dinfo);
+	lv1_gpu_fb_close(ps3fb.context_handle);
 	lv1_gpu_context_iomap(ps3fb.context_handle, GPU_IOIF, xdr_lpar,
 			      ps3fb_videomemory.size, IOPTE_M);
 	lv1_gpu_context_free(ps3fb.context_handle);
-- 
1.6.2.4


  reply	other threads:[~2009-05-08 14:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 14:01 [PATCH 0/15] ps3{fb,vram,disk} patches for 2.6.31 Geert Uytterhoeven
2009-05-08 14:01 ` [PATCH 01/15] ps3vram: Fix error path (return -EIO) for short read/write Geert Uytterhoeven
2009-05-08 14:01   ` [PATCH 02/15] ps3vram: Use proc_create_data() instead of proc_create() Geert Uytterhoeven
2009-05-08 14:01     ` [PATCH 03/15] ps3vram: Correct exchanged gotos in ps3vram_probe() error path Geert Uytterhoeven
2009-05-08 14:01       ` [PATCH 04/15] ps3vram: Replace mutex by spinlock + list Geert Uytterhoeven
2009-05-08 14:01         ` [PATCH 05/15] ps3fb: Remove useless debug checks in ps3fb_shutdown() Geert Uytterhoeven
2009-05-08 14:01           ` [PATCH 06/15] ps3fb: Inline functions in ps3fb_probe(), to ease cleanup in the error path Geert Uytterhoeven
2009-05-08 14:01             ` [PATCH 07/15] ps3fb: Correct handling of device opening in ps3fb_probe() Geert Uytterhoeven
2009-05-08 14:01               ` [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h> Geert Uytterhoeven
2009-05-08 14:01                 ` [PATCH 09/15] ps3fb: GPU memory mapping cleanup Geert Uytterhoeven
2009-05-08 14:01                   ` [PATCH 10/15] ps3vram: " Geert Uytterhoeven
2009-05-08 14:01                     ` [PATCH 11/15] ps3fb/vram: Extract common GPU stuff into <asm/ps3gpu.h> Geert Uytterhoeven
2009-05-08 14:01                       ` Geert Uytterhoeven [this message]
2009-05-08 14:01                         ` [PATCH 13/15] ps3vram: Remove no longer used ps3vram_priv.ddr_base Geert Uytterhoeven
2009-05-08 14:01                           ` [PATCH 14/15] ps3vram: Make ps3vram_priv.reports a void * Geert Uytterhoeven
2009-05-08 14:01                             ` [PATCH 15/15] block/ps3: remove driver_data direct access of struct device Geert Uytterhoeven
2009-05-10 19:08                 ` [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h> Christoph Hellwig
2009-05-11  7:24                   ` Geert Uytterhoeven
2009-05-08 23:05         ` [PATCH 04/15] ps3vram: Replace mutex by spinlock + list Andrew Morton
2009-05-11  6:38           ` Geert Uytterhoeven
2009-05-10 19:05         ` [Cbe-oss-dev] " Christoph Hellwig
2009-05-11 14:20           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241791284-11490-13-git-send-email-Geert.Uytterhoeven@sonycom.com \
    --to=geert.uytterhoeven@sonycom.com \
    --cc=benh@kernel.crashing.org \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®