From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] Replace wait_noreap_copyout() by copy_wait_opts_to_user()
Date: Wed, 13 May 2009 14:08:12 +0200 [thread overview]
Message-ID: <1242216490-8226-3-git-send-email-v.mayatskih@gmail.com> (raw)
In-Reply-To: <1242216490-8226-1-git-send-email-v.mayatskih@gmail.com>
wait_noreap_copyout() currently is a short wrapper for
copy_wait_opts_to_user(), and wait_task_zombie() is the only one caller
of it.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
---
kernel/exit.c | 17 +++++------------
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/kernel/exit.c b/kernel/exit.c
index f069bc1..cea85c9 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -1154,17 +1154,6 @@ static int copy_wait_opts_to_user(struct wait_opts *wo, struct wait_info *wi)
return retval;
}
-static int wait_noreap_copyout(struct wait_opts *wo, struct wait_info *wi)
-{
- int retval;
- wi->signal = SIGCHLD;
- retval = copy_wait_opts_to_user(wo, wi);
- put_task_struct(wi->p);
- if (!retval)
- retval = wi->pid;
- return retval;
-}
-
/*
* Handle sys_wait4 work for one task in state EXIT_ZOMBIE. We hold
* read_lock(&tasklist_lock) on entry. If we return zero, we still hold
@@ -1194,7 +1183,11 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p)
wi.why = (wi.status & 0x80) ? CLD_DUMPED : CLD_KILLED;
wi.status &= 0x7f;
}
- return wait_noreap_copyout(wo, &wi);
+ retval = copy_wait_opts_to_user(wo, &wi);
+ put_task_struct(p);
+ if (!retval)
+ retval = wi.pid;
+ return retval;
}
/*
--
1.6.2.2
next prev parent reply other threads:[~2009-05-13 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 12:08 [PATCH 0/3] More cleanups in do_wait() pathes Vitaly Mayatskikh
2009-05-13 12:08 ` [PATCH 1/3] Introduce "struct wait_info" to simplify wait_task*() pathes Vitaly Mayatskikh
2009-05-13 18:13 ` Roland McGrath
2009-05-13 19:05 ` Vitaly Mayatskikh
2009-05-15 17:37 ` Ingo Molnar
2009-05-16 10:45 ` Vitaly Mayatskikh
2009-05-13 12:08 ` Vitaly Mayatskikh [this message]
2009-05-13 12:08 ` [PATCH 3/3] Move more common code from wait_task_*() to copy_wait_opts_to_user() Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242216490-8226-3-git-send-email-v.mayatskih@gmail.com \
--to=v.mayatskih@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®