From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757794AbZEOS45 (ORCPT ); Fri, 15 May 2009 14:56:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753241AbZEOS4r (ORCPT ); Fri, 15 May 2009 14:56:47 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:59746 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbZEOS4q (ORCPT ); Fri, 15 May 2009 14:56:46 -0400 Subject: Re: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug( From: James Bottomley To: Joe Perches Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Date: Fri, 15 May 2009 18:56:46 +0000 Message-Id: <1242413806.22585.2.camel@mulgrave.int.hansenpartnership.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote: > From: Joe Perches > > Signed-off-by: Joe Perches > --- > drivers/scsi/aha1542.c | 8 ++------ > 1 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c > index 8059494..29d5118 100644 > --- a/drivers/scsi/aha1542.c > +++ b/drivers/scsi/aha1542.c > @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost) > if (mbistatus == 3) > continue; /* Aborted command not found */ > > -#ifdef DEBUG > - printk(KERN_DEBUG "...done %d %d\n", mbo, mbi); > -#endif > + pr_debug("...done %d %d\n", mbo, mbi); This one looks dangerous ... that's a per trigger printk from interrupt context. That's a lot of stuff to bung in the log buffer for a normal operating case (which is pretty interrupt heavy). What does this do to system responsiveness? James