mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>,
	Borislav Petkov <petkovbb@gmail.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Andrew Morton <akpm@linux-foundation.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info(
Date: Sun, 17 May 2009 19:31:33 -0700	[thread overview]
Message-ID: <1242613893.29902.2.camel@Joe-Laptop.home> (raw)
In-Reply-To: <3e6c44e2b4365598d80940c292bef91a835ab30d.1242609803.git.joe@perches.com>

On Sun, 2009-05-17 at 19:21 -0700, Joe Perches wrote:
> diff --git a/drivers/ide/aec62xx.c b/drivers/ide/aec62xx.c
> index 878f8ec..d2f9293 100644
> --- a/drivers/ide/aec62xx.c
> +++ b/drivers/ide/aec62xx.c
> @@ -273,8 +273,8 @@ static int __devinit aec62xx_init_one(struct pci_dev *dev, const struct pci_devi
>  		unsigned long dma_base = pci_resource_start(dev, 4);
>  
>  		if (inb(dma_base + 2) & 0x10) {
> -			printk(KERN_INFO DRV_NAME " %s: AEC6880%s card detected"
> -				"\n", pci_name(dev), (idx == 4) ? "R" : "");
> +			pr_info(DRV_NAME " %s: AEC6880%s card detected\n"
> +				pci_name(dev), (idx == 4) ? "R" : "");
>  			d.udma_mask = ATA_UDMA6;
>  		}
>  	}

Sorry, this one is bad.  It's missing a comma between the
end of the format string and pci_name.

I edited it in-place and neglected to remove the backup file.
git send-email sent the corrected patch and the backup file.

The other [patch 2/6] is correct.


  reply	other threads:[~2009-05-18  2:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18  2:21 [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Joe Perches
2009-05-18  2:21 ` [PATCH 1/6] drivers/ide: Convert printk(KERN_DEBUG to pr_debug( Joe Perches
2009-05-18  9:34   ` Sergei Shtylyov
2009-05-18  2:21 ` [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info( Joe Perches
2009-05-18  2:31   ` Joe Perches [this message]
2009-05-18  2:21 ` [PATCH 3/6] drivers/ide: Convert printk(KERN_ERR to pr_err( Joe Perches
2009-05-18  2:21 ` [PATCH 4/6] drivers/ide: Convert printk(KERN_WARNING to pr_warning( Joe Perches
2009-05-18  2:21 ` [PATCH 5/6] drivers/ide: Convert printk(KERN_CONT to pr_cont( Joe Perches
2009-05-18  2:21 ` [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( Joe Perches
2009-05-18 10:11   ` Sergei Shtylyov
2009-05-18 13:22     ` Krzysztof Halasa
2009-05-18 13:38       ` Sergei Shtylyov
2009-05-18 13:50       ` Bartlomiej Zolnierkiewicz
2009-05-18 17:18         ` Krzysztof Halasa
2009-05-18 18:55       ` Alan Cox
2009-05-18 13:32     ` Joe Perches
2009-05-18 14:12 ` [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Bartlomiej Zolnierkiewicz
2009-05-18 15:41   ` Joe Perches
2009-05-18 15:48     ` Bartlomiej Zolnierkiewicz
2009-05-18 15:56     ` James Bottomley
2009-05-18 20:59       ` Joe Perches
2009-05-18 21:15         ` James Bottomley
2009-05-18 21:21           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242613893.29902.2.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=bzolnier@gmail.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=sshtylyov@ru.mvista.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®