From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756784AbZETRZ0 (ORCPT ); Wed, 20 May 2009 13:25:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753935AbZETRZR (ORCPT ); Wed, 20 May 2009 13:25:17 -0400 Received: from 136-022.dsl.LABridge.com ([206.117.136.22]:4620 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753210AbZETRZQ (ORCPT ); Wed, 20 May 2009 13:25:16 -0400 From: Joe Perches To: linux-kernel@vger.kernel.org Cc: H Hartley Sweeten , linux-mm@kvack.org, Matt Mackall , Pekka Enberg , Christoph Lameter , Ingo Molnar , David Rientjes , Eduard - Gabriel Munteanu Subject: [PATCH] mm/slub.c: Use print_hex_dump and remove unnecessary cast Date: Wed, 20 May 2009 10:25:13 -0700 Message-Id: <1242840314-25635-1-git-send-email-joe@perches.com> X-Mailer: git-send-email 1.6.3.1.10.g659a0.dirty Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Joe Perches --- mm/slub.c | 34 ++++------------------------------ 1 files changed, 4 insertions(+), 30 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 65ffda5..5b616d6 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -328,36 +328,10 @@ static char *slub_debug_slabs; /* * Object debugging */ -static void print_section(char *text, u8 *addr, unsigned int length) +static void print_section(const char *text, u8 *addr, unsigned int length) { - int i, offset; - int newline = 1; - char ascii[17]; - - ascii[16] = 0; - - for (i = 0; i < length; i++) { - if (newline) { - printk(KERN_ERR "%8s 0x%p: ", text, addr + i); - newline = 0; - } - printk(KERN_CONT " %02x", addr[i]); - offset = i % 16; - ascii[offset] = isgraph(addr[i]) ? addr[i] : '.'; - if (offset == 15) { - printk(KERN_CONT " %s\n", ascii); - newline = 1; - } - } - if (!newline) { - i %= 16; - while (i < 16) { - printk(KERN_CONT " "); - ascii[i] = ' '; - i++; - } - printk(KERN_CONT " %s\n", ascii); - } + print_hex_dump(KERN_ERR, text, DUMP_PREFIX_ADDRESS, 16, 1, + addr, length, true); } static struct track *get_track(struct kmem_cache *s, void *object, @@ -794,7 +768,7 @@ static void trace(struct kmem_cache *s, struct page *page, void *object, page->freelist); if (!alloc) - print_section("Object", (void *)object, s->objsize); + print_section("Object", object, s->objsize); dump_stack(); } -- 1.6.3.1.10.g659a0.dirty