From: Borislav Petkov <borislav.petkov@amd.com>
To: <akpm@linux-foundation.org>, <greg@kroah.com>, <mingo@elte.hu>
Cc: <norsk5@yahoo.com>, <tglx@linutronix.de>, <hpa@zytor.com>,
<mchehab@redhat.com>, <aris@redhat.com>,
edt@aei.ca, <linux-kernel@vger.kernel.org>,
randy.dunlap@oracle.com,
Alexander Beregalov <a.beregalov@gmail.com>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH 1/4] x86: msr.h: fix build error
Date: Wed, 20 May 2009 20:43:54 +0200 [thread overview]
Message-ID: <1242845037-1029-2-git-send-email-borislav.petkov@amd.com> (raw)
In-Reply-To: <1242845037-1029-1-git-send-email-borislav.petkov@amd.com>
From: Alexander Beregalov <a.beregalov@gmail.com>
Fix this build error:
.../asm/msr.h: In function 'rdmsr_on_cpus':
.../asm/msr.h:248: error: request for member 'l' in something not a structure or union
.../asm/msr.h:248: error: request for member 'h' in something not a structure or union
.../asm/msr.h:248: error: too few arguments to function 'rdmsr_on_cpu'
.../asm/msr.h: In function 'wrmsr_on_cpus':
.../asm/msr.h:253: error: request for member 'l' in something not a structure or union
.../asm/msr.h:253: error: request for member 'h' in something not a structure or union
.../asm/msr.h:253: error: too few arguments to function 'wrmsr_on_cpu'
This is !SMP code so `cpu` should be 0.
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
arch/x86/include/asm/msr.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index e49c14e..fa082ba 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -243,14 +243,14 @@ static inline int wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
return 0;
}
static inline int rdmsr_on_cpus(const cpumask_t *m, u32 msr_no,
- struct msr **msrs)
+ struct msr *msrs)
{
- return rdmsr_on_cpu(msr_no, &(msrs[0].l), &(msrs[0].h));
+ return rdmsr_on_cpu(0, msr_no, &(msrs[0].l), &(msrs[0].h));
}
static inline int wrmsr_on_cpus(const cpumask_t *m, u32 msr_no,
- struct msr **msrs)
+ struct msr *msrs)
{
- return wrmsr_on_cpu(msr_no, msrs[0].l, msrs[0].h);
+ return wrmsr_on_cpu(0, msr_no, msrs[0].l, msrs[0].h);
}
static inline int rdmsr_safe_on_cpu(unsigned int cpu, u32 msr_no,
u32 *l, u32 *h)
--
1.6.2.4
next prev parent reply other threads:[~2009-05-20 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 18:43 [PATCH 0/4] amd64_edac: misc fixes Borislav Petkov
2009-05-20 18:43 ` Borislav Petkov [this message]
2009-05-20 18:43 ` [PATCH 2/4] amd64_edac: do not enable module by default Borislav Petkov
2009-05-20 18:43 ` [PATCH 3/4] EDAC: do not enable modules " Borislav Petkov
2009-05-20 18:43 ` [PATCH 4/4] amd64_edac: add MAINTAINERS entry Borislav Petkov
2009-05-20 21:41 ` [PATCH 0/4] amd64_edac: misc fixes Randy Dunlap
2009-05-28 23:47 ` Andrew Morton
2009-05-29 10:33 ` Borislav Petkov
2009-05-29 20:01 ` Andrew Morton
2009-05-30 8:19 ` Borislav Petkov
2009-05-30 8:40 ` Andrew Morton
2009-05-30 10:31 ` Borislav Petkov
2009-05-30 19:22 ` H. Peter Anvin
2009-06-01 14:53 ` Borislav Petkov
2009-06-01 16:54 ` H. Peter Anvin
2009-06-01 17:02 ` H. Peter Anvin
2009-06-01 17:31 ` H.J. Lu
2009-06-01 18:12 ` Borislav Petkov
2009-06-01 18:57 ` H. Peter Anvin
2009-06-03 18:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242845037-1029-2-git-send-email-borislav.petkov@amd.com \
--to=borislav.petkov@amd.com \
--cc=a.beregalov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aris@redhat.com \
--cc=edt@aei.ca \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@elte.hu \
--cc=norsk5@yahoo.com \
--cc=randy.dunlap@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome