mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 03/12] amd-iommu: handle page table allocation failures in dma_ops code
Date: Fri, 22 May 2009 14:21:24 +0200	[thread overview]
Message-ID: <1242994893-28902-4-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1242994893-28902-1-git-send-email-joerg.roedel@amd.com>

[ impact: preperation for extended address allocator ]

The code will be required when the aperture size increases dynamically.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/amd_iommu.c |   20 ++++++++++++++++++--
 1 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index ded79f7..a467add 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -1193,6 +1193,8 @@ static dma_addr_t dma_ops_domain_map(struct amd_iommu *iommu,
 	paddr &= PAGE_MASK;
 
 	pte  = dma_ops_get_pte(dom, address);
+	if (!pte)
+		return bad_dma_address;
 
 	__pte = paddr | IOMMU_PTE_P | IOMMU_PTE_FC;
 
@@ -1248,7 +1250,7 @@ static dma_addr_t __map_single(struct device *dev,
 			       u64 dma_mask)
 {
 	dma_addr_t offset = paddr & ~PAGE_MASK;
-	dma_addr_t address, start;
+	dma_addr_t address, start, ret;
 	unsigned int pages;
 	unsigned long align_mask = 0;
 	int i;
@@ -1271,7 +1273,10 @@ static dma_addr_t __map_single(struct device *dev,
 
 	start = address;
 	for (i = 0; i < pages; ++i) {
-		dma_ops_domain_map(iommu, dma_dom, start, paddr, dir);
+		ret = dma_ops_domain_map(iommu, dma_dom, start, paddr, dir);
+		if (ret == bad_dma_address)
+			goto out_unmap;
+
 		paddr += PAGE_SIZE;
 		start += PAGE_SIZE;
 	}
@@ -1287,6 +1292,17 @@ static dma_addr_t __map_single(struct device *dev,
 
 out:
 	return address;
+
+out_unmap:
+
+	for (--i; i >= 0; --i) {
+		start -= PAGE_SIZE;
+		dma_ops_domain_unmap(iommu, dma_dom, start);
+	}
+
+	dma_ops_free_addresses(dma_dom, address, pages);
+
+	return bad_dma_address;
 }
 
 /*
-- 
1.6.3.1



  parent reply	other threads:[~2009-05-22 12:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 12:21 [PATCH 0/12] extended allocator for amd iommu Joerg Roedel
2009-05-22 12:21 ` [PATCH 01/12] amd-iommu: introduce aperture_range structure Joerg Roedel
2009-05-22 12:21 ` [PATCH 02/12] amd-iommu: move page table allocation code to seperate function Joerg Roedel
2009-05-22 12:21 ` Joerg Roedel [this message]
2009-05-22 12:21 ` [PATCH 04/12] amd-iommu: make address allocator aware of multiple aperture ranges Joerg Roedel
2009-05-22 12:21 ` [PATCH 05/12] amd-iommu: change dma_dom->next_bit to dma_dom->next_address Joerg Roedel
2009-05-22 12:21 ` [PATCH 06/12] amd-iommu: move aperture_range allocation code to seperate function Joerg Roedel
2009-05-22 12:21 ` [PATCH 07/12] amd-iommu: handle exlusion ranges and unity mappings in alloc_new_range Joerg Roedel
2009-05-22 12:21 ` [PATCH 08/12] amd-iommu: enlarge the aperture dynamically Joerg Roedel
2009-05-22 12:21 ` [PATCH 09/12] amd-iommu: remove amd_iommu_size kernel parameter Joerg Roedel
2009-05-22 12:21 ` [PATCH 10/12] amd-iommu: disable round-robin allocator for CONFIG_IOMMU_STRESS Joerg Roedel
2009-05-22 12:21 ` [PATCH 11/12] amd-iommu: don't preallocate page tables with CONFIG_IOMMU_STRESS Joerg Roedel
2009-05-22 12:21 ` [PATCH 12/12] amd-iommu: don't free dma adresses below 512MB " Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242994893-28902-4-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®