mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Zhenwen Xu <helight.xu@gmail.com>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] forget a blankspace before 'name'
Date: Sat, 23 May 2009 09:13:36 -0400	[thread overview]
Message-ID: <1243084416.7675.0.camel@dhcp231-142.rdu.redhat.com> (raw)
In-Reply-To: <20090523101049.GA7209@helight>

On Sat, 2009-05-23 at 18:10 +0800, Zhenwen Xu wrote:
> here should add some space before "name="

NAK.

/* This is a helper-function to print the escaped d_path */
void audit_log_d_path(struct audit_buffer *ab, const char *prefix,
                      struct path *path)
{
        char *p, *pathname;

        if (prefix)
                audit_log_format(ab, " %s", prefix);

Look there, a space before the prefix.




> Signed-off-by: Zhenwen Xu <helight.xu@gmail.com>
> ---
>  kernel/auditsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 7d6ac7c..aa0428e 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1478,7 +1478,7 @@ static void audit_log_exit(struct audit_context *context, struct task_struct *ts
>  			case 0:
>  				/* name was specified as a relative path and the
>  				 * directory component is the cwd */
> -				audit_log_d_path(ab, "name=", &context->pwd);
> +				audit_log_d_path(ab, " name=", &context->pwd);
>  				break;
>  			default:
>  				/* log the name's directory component */
> -- 
> 1.5.6.5
> 


      reply	other threads:[~2009-05-23 13:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 10:10 Zhenwen Xu
2009-05-23 13:13 ` Eric Paris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243084416.7675.0.camel@dhcp231-142.rdu.redhat.com \
    --to=eparis@redhat.com \
    --cc=helight.xu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®