From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbcKHOm6 (ORCPT ); Tue, 8 Nov 2016 09:42:58 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44936 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbcKHOmz (ORCPT ); Tue, 8 Nov 2016 09:42:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 0FDD4623C9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] dmaengine: qcom_hidma: hide MSI handler when unused To: Arnd Bergmann , Vinod Koul References: <20161108134937.1966206-1-arnd@arndb.de> Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org From: Sinan Kaya Message-ID: <1243177a-b76f-e9ef-5a1f-f318947d016b@codeaurora.org> Date: Tue, 8 Nov 2016 09:42:52 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161108134937.1966206-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/2016 8:48 AM, Arnd Bergmann wrote: > The newly added MSI support causes a harmless warning when MSI > is disabled: > > drivers/dma/qcom/hidma.c:558:20: error: 'hidma_chirq_handler_msi' defined but not used [-Werror=unused-function] > > This adds another #ifdef to match that around the users of the function. > > Fixes: 1c0e3e82a7fb ("dmaengine: qcom_hidma: add MSI support for interrupts") > Signed-off-by: Arnd Bergmann Thanks for the clean up. Acked-by: Sinan Kaya > --- > drivers/dma/qcom/hidma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c > index d5e7991ad737..10425e134e06 100644 > --- a/drivers/dma/qcom/hidma.c > +++ b/drivers/dma/qcom/hidma.c > @@ -555,6 +555,7 @@ static irqreturn_t hidma_chirq_handler(int chirq, void *arg) > return hidma_ll_inthandler(chirq, lldev); > } > > +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN > static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg) > { > struct hidma_lldev **lldevp = arg; > @@ -563,6 +564,7 @@ static irqreturn_t hidma_chirq_handler_msi(int chirq, void *arg) > return hidma_ll_inthandler_msi(chirq, *lldevp, > 1 << (chirq - dmadev->msi_virqbase)); > } > +#endif > > static ssize_t hidma_show_values(struct device *dev, > struct device_attribute *attr, char *buf) > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.