mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Borislav Petkov <petkovbb@gmail.com>, Tejun Heo <tj@kernel.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_<level> and dev_<level>
Date: Sun, 24 May 2009 09:46:36 -0700	[thread overview]
Message-ID: <1243183596.3560.19.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4A19399B.8060207@ru.mvista.com>

On Sun, 2009-05-24 at 16:12 +0400, Sergei Shtylyov wrote:
> > -		dev_err(&drive->gendev, "%s: packet size (0x%02x) is not 12 "
> > -			"bytes\n", s, packet_size);
> > +		dev_err(&drive->gendev,
> > +			"%s: packet size (0x%02x) is not 12 bytes\n",
>    When the message is broken by the format specifier, turning it into 
> one liner can hardly help seraching...

grep "is not 12 bytes"

>    Oh noes, the indentation...

trade-offs...

> > +	"(IO,CoD != (0,1) while issuing a packet command, retrying\n");
>    Sigh...

You seem to sigh a lot.  ;)

> > +	"(IO,CoD != (0,1) while issuing a packet command, ignoring\n");
>    Sigh...
> > +	"Strange, packet command initiated yet DRQ isn't asserted\n");
>    Sigh...
> > +		"(IO,CoD) != (0,1) while issuing a packet command\n");
>    Sigh...
> > +		"unexpected interrupt, status=0x%02x, count=%ld\n",
>    Hardly won anything...
> > + "%s side 80-wire cable detection failed, limiting max speed to UDMA33\n",
>     Will you really use the full message to serch here?
> > +		 "probing with STATUS(0x%02x) instead of ALTSTATUS(0x%02x)\n",
>    Same comment about the line broken by the format specifiers. This 
> wins absolutely nothing.

grep "STATUS.*ALTSTATUS"

> > +		"no response (status = 0x%02x), resetting drive\n",
>    And again...

grep "response.*resetting"

> > +			"%s Multimode Write multcount is not set\n",
>    Sigh...
> > +			"%s Multimode Read failure multcount is not set\n",
>    Sigh...
> > +		"%s %s: device not capable of full native PCI mode\n",
>    Sigh...
> > +		"%s %s: rewrite of PROGIF failed, wanted 0x%04x, got 0x%04x\n",
> > +		"%s %s: I/O baseregs (BIOS) are reported as MEM for port %d!\n",
>    Sigh...
> > +		"%s %s: not 100%% native mode: will probe irqs later\n",
>    Sigh...

cheers, Joe


  reply	other threads:[~2009-05-24 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23  7:41 [PATCH 0/3] drivers/ide/ide-core: Use dev_<level> and pr_<level> Joe Perches
2009-05-23  7:41 ` [PATCH 1/3] drivers/ide/ide-core: Convert printk(KERN_<level> to dev_<level> Joe Perches
2009-06-02 13:57   ` Bartlomiej Zolnierkiewicz
2009-05-23  7:41 ` [PATCH 2/3] drivers/ide/ide-core: Convert printk(KERN_<level> to pr_<level> Joe Perches
2009-06-02 14:02   ` Bartlomiej Zolnierkiewicz
2009-05-23  7:41 ` [PATCH 3/3] drivers/ide/ide-core: Unsplit constant strings for pr_<level> and dev_<level> Joe Perches
2009-05-24 12:12   ` Sergei Shtylyov
2009-05-24 16:46     ` Joe Perches [this message]
2009-05-24 18:00       ` Sergei Shtylyov
2009-06-02 14:19     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243183596.3560.19.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=sshtylyov@ru.mvista.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®