From: David Woodhouse <dwmw2@infradead.org>
To: Kevin Cernekee <kpc.mtd@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Adrian Hunter <adrian.hunter@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MTD <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup
Date: Fri, 29 May 2009 15:58:06 +0100 [thread overview]
Message-ID: <1243609086.19886.179.camel@macbook.infradead.org> (raw)
In-Reply-To: <a95a62fe0904082253i119f8660y6a73835a163394f5@mail.gmail.com>
On Wed, 2009-04-08 at 22:53 -0700, Kevin Cernekee wrote:
>
> +static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
> + unsigned long arg)
> +{
> + struct mtd_file_info *mfi = file->private_data;
> + struct mtd_info *mtd = mfi->mtd;
> + void __user *argp = (void __user *)arg;
Shouldn't that be 'argp = compat_ptr(arg)' ?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-05-29 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 5:53 Kevin Cernekee
2009-04-14 14:43 ` Arnd Bergmann
2009-05-29 15:04 ` David Woodhouse
2009-05-29 15:12 ` David Woodhouse
2009-05-29 14:58 ` David Woodhouse [this message]
2009-05-29 15:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243609086.19886.179.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=adrian.hunter@nokia.com \
--cc=arnd@arndb.de \
--cc=kpc.mtd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®