From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761663AbZE2PEk (ORCPT ); Fri, 29 May 2009 11:04:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759998AbZE2PEc (ORCPT ); Fri, 29 May 2009 11:04:32 -0400 Received: from casper.infradead.org ([85.118.1.10]:34484 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759542AbZE2PEb (ORCPT ); Fri, 29 May 2009 11:04:31 -0400 Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup From: David Woodhouse To: Arnd Bergmann Cc: Kevin Cernekee , Adrian Hunter , "linux-kernel@vger.kernel.org" , Linux MTD In-Reply-To: <200904141643.48345.arnd@arndb.de> References: <200904141643.48345.arnd@arndb.de> Content-Type: text/plain Date: Fri, 29 May 2009 16:04:29 +0100 Message-Id: <1243609469.19886.180.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2009-04-14 at 16:43 +0200, Arnd Bergmann wrote: > This looks correct, but I think it would be better to just remove all > those lines from fs/compat_ioctl.c and add a default: statement in > mtd_compat_ioctl that calls mtd_ioctl for all ioctl numbers that > don't have an explicit handler. He did that already; I've just committed it to my local tree and will be pushing it out as soon as I fix the compat_ptr() thing. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation