From: Matthew Garrett <mjg@redhat.com>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 3/3] dell-wmi: Don't generate errors on empty messages
Date: Mon, 1 Jun 2009 15:14:37 +0100 [thread overview]
Message-ID: <1243865677-25425-3-git-send-email-mjg@redhat.com> (raw)
In-Reply-To: <1243865677-25425-2-git-send-email-mjg@redhat.com>
There's no point in generating kernel messages if we didn't receive a
parsable keyboard event - only do so if there appeared to be a scancode.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
drivers/platform/x86/dell-wmi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 9f345dc..0f900cc 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -176,9 +176,9 @@ static void dell_wmi_notify(u32 value, void *context)
input_sync(dell_wmi_input_dev);
input_report_key(dell_wmi_input_dev, key->keycode, 0);
input_sync(dell_wmi_input_dev);
- } else
+ } else if (buffer[1] & 0xFFFF)
printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n",
- buffer[1]);
+ buffer[1] & 0xFFFF);
}
}
--
1.6.2.2
next prev parent reply other threads:[~2009-06-01 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 14:14 [PATCH 1/3] dell-wmi: Mask off upper bytes of event response Matthew Garrett
2009-06-01 14:14 ` [PATCH 2/3] dell-wmi: Add additional keyboard events Matthew Garrett
2009-06-01 14:14 ` Matthew Garrett [this message]
2009-06-18 3:45 ` [PATCH 3/3] dell-wmi: Don't generate errors on empty messages Len Brown
2009-06-18 3:45 ` [PATCH 2/3] dell-wmi: Add additional keyboard events Len Brown
2009-06-18 3:45 ` [PATCH 1/3] dell-wmi: Mask off upper bytes of event response Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243865677-25425-3-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®