mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"K.Prasad" <prasad@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 09/12] hw-breakpoints: cleanup HW Breakpoint registers before kexec
Date: Wed,  3 Jun 2009 00:43:33 +0200	[thread overview]
Message-ID: <1243982616-18212-10-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1243982616-18212-1-git-send-email-fweisbec@gmail.com>

From: K.Prasad <prasad@linux.vnet.ibm.com>

This patch disables Hardware breakpoints before doing a 'kexec' on the machine
so that the cpu doesn't keep debug registers values which would be out of
sync for the new image.

Original-patch-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: K.Prasad <prasad@linux.vnet.ibm.com>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 arch/x86/kernel/machine_kexec_32.c |    2 ++
 arch/x86/kernel/machine_kexec_64.c |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/machine_kexec_32.c b/arch/x86/kernel/machine_kexec_32.c
index c1c429d..c843f84 100644
--- a/arch/x86/kernel/machine_kexec_32.c
+++ b/arch/x86/kernel/machine_kexec_32.c
@@ -25,6 +25,7 @@
 #include <asm/desc.h>
 #include <asm/system.h>
 #include <asm/cacheflush.h>
+#include <asm/debugreg.h>
 
 static void set_idt(void *newidt, __u16 limit)
 {
@@ -202,6 +203,7 @@ void machine_kexec(struct kimage *image)
 
 	/* Interrupts aren't acceptable while we reboot */
 	local_irq_disable();
+	hw_breakpoint_disable();
 
 	if (image->preserve_context) {
 #ifdef CONFIG_X86_IO_APIC
diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
index 84c3bf2..4a8bb82 100644
--- a/arch/x86/kernel/machine_kexec_64.c
+++ b/arch/x86/kernel/machine_kexec_64.c
@@ -18,6 +18,7 @@
 #include <asm/pgtable.h>
 #include <asm/tlbflush.h>
 #include <asm/mmu_context.h>
+#include <asm/debugreg.h>
 
 static int init_one_level2_page(struct kimage *image, pgd_t *pgd,
 				unsigned long addr)
@@ -282,6 +283,7 @@ void machine_kexec(struct kimage *image)
 
 	/* Interrupts aren't acceptable while we reboot */
 	local_irq_disable();
+	hw_breakpoint_disable();
 
 	if (image->preserve_context) {
 #ifdef CONFIG_X86_IO_APIC
-- 
1.6.2.3


  parent reply	other threads:[~2009-06-02 22:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 22:43 [PATCH 00/12] hw-breakpoints: new hardware breakpoints API Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 01/12] hw-breakpoints: prepare the code for Hardware Breakpoint interfaces Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 02/12] hw-breakpoints: introducing generic hardware breakpoint handler interfaces Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 03/12] hw-breakpoints: x86 architecture implementation of Hardware Breakpoint interfaces Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 04/12] hw-breakpoints: modifying generic debug exception to use thread-specific debug registers Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 05/12] hw-breakpoints: use wrapper routines around debug registers in processor related functions Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 06/12] hw-breakpoints: use the new wrapper routines to access debug registers in process/thread code Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 07/12] hw-breakpoints: modify signal handling code to refrain from re-enabling HW Breakpoints Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 08/12] hw-breakpoints: modify Ptrace routines to access breakpoint registers Frederic Weisbecker
2009-06-02 22:43 ` Frederic Weisbecker [this message]
2009-06-02 22:43 ` [PATCH 10/12] hw-breakpoints: sample HW breakpoint over kernel data address Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 11/12] hw-breakpoints: ftrace plugin for kernel symbol tracing using HW Breakpoint interfaces Frederic Weisbecker
2009-06-02 23:12   ` David Daney
2009-06-03  0:38     ` Frederic Weisbecker
2009-06-03 16:03       ` David Daney
2009-06-04 15:45       ` K.Prasad
2009-06-05 11:44         ` Frederic Weisbecker
2009-06-04 15:36     ` K.Prasad
2009-06-05 11:37       ` Frederic Weisbecker
2009-06-02 22:43 ` [PATCH 12/12] hw-breakpoints: reset bits in dr6 after the corresponding exception is handled Frederic Weisbecker
2009-06-02 23:38 ` [PATCH 00/12] hw-breakpoints: new hardware breakpoints API Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243982616-18212-10-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=prasad@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome