From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, davem@davemloft.net,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sergey Lapin <slapin@ossfans.org>
Subject: Re: [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices
Date: Wed, 03 Jun 2009 11:39:24 +0200 [thread overview]
Message-ID: <1244021964.10665.5.camel@johannes.local> (raw)
In-Reply-To: <1244021629-18409-5-git-send-email-dbaryshkov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Wed, 2009-06-03 at 13:33 +0400, Dmitry Eremin-Solenikov wrote:
> +enum {
> + __IEEE802154_COMMAND_INVALID,
> +
> + IEEE802154_ASSOCIATE_REQ,
> + IEEE802154_ASSOCIATE_CONF,
> + IEEE802154_DISASSOCIATE_REQ,
> + IEEE802154_DISASSOCIATE_CONF,
> + IEEE802154_GET_REQ,
> + IEEE802154_GET_CONF,
> +/* IEEE802154_GTS_REQ, */
> +/* IEEE802154_GTS_CONF, */
> + IEEE802154_RESET_REQ,
> + IEEE802154_RESET_CONF,
> +/* IEEE802154_RX_ENABLE_REQ, */
> +/* IEEE802154_RX_ENABLE_CONF, */
This is a recipe for disaster. Somebody will come along and uncomment
things. Why this is bad, I leave as an exercise for the reader.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-06-03 9:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 9:33 [MERGE REQUEST] IEEE 802.15.4 stack: generic parts Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 1/6] crc-itu-t: add bit-reversed calculation Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 2/6] Add constants for the ieee 802.15.4/ZigBee stack Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 3/6] net: add IEEE 802.15.4 socket family implementation Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 5/6] ieee802154: add documentation about our stack Dmitry Eremin-Solenikov
2009-06-03 9:33 ` [PATCH 6/6] ieee802154: add simple HardMAC driver sample Dmitry Eremin-Solenikov
2009-06-03 9:39 ` Johannes Berg [this message]
2009-06-03 10:09 ` [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices David Miller
2009-06-03 10:52 ` Dmitry Eremin-Solenikov
2009-06-03 11:05 ` Johannes Berg
2009-06-03 12:27 ` Dmitry Eremin-Solenikov
2009-06-04 14:12 ` Johannes Berg
2009-06-04 14:51 ` Dmitry Eremin-Solenikov
2009-06-04 15:12 ` Patrick McHardy
2009-06-04 15:14 ` Dmitry Eremin-Solenikov
2009-06-04 15:15 ` Patrick McHardy
2009-06-03 12:55 ` Sergey Lapin
2009-06-03 14:21 ` Patrick McHardy
2009-06-03 23:12 ` Dmitry Eremin-Solenikov
2009-06-03 10:08 ` [PATCH 2/6] Add constants for the ieee 802.15.4/ZigBee stack David Miller
2009-06-03 10:51 ` Dmitry Eremin-Solenikov
2009-06-03 21:19 ` David Miller
2009-06-03 23:15 ` Dmitry Eremin-Solenikov
2009-06-04 0:49 ` David Miller
2009-06-03 12:43 ` [PATCH 1/6] crc-itu-t: add bit-reversed calculation Ben Hutchings
2009-06-03 12:48 ` Dmitry Eremin-Solenikov
2009-06-04 0:49 ` Dmitry Eremin-Solenikov
2009-06-21 8:29 ` Dmitry Eremin-Solenikov
2009-06-21 10:18 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244021964.10665.5.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=slapin@ossfans.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®