From: Suresh Siddha <suresh.b.siddha@intel.com>
To: mingo@elte.hu, hpa@zytor.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, ebiederm@xmission.com,
andi@linux.intel.com, travis@sgi.com, steiner@sgi.com
Subject: [patch] x64: Avoid irq_chip mask/unmask in fixup_irqs for interrupt-remapping
Date: Thu, 04 Jun 2009 11:59:49 -0700 [thread overview]
Message-ID: <1244141989.27006.10369.camel@localhost.localdomain> (raw)
From: Suresh Siddha <suresh.b.siddha@intel.com>
Subject: x64: Avoid irq_chip mask/unmask in fixup_irqs for interrupt-remapping
In the presence of interrupt-remapping, irqs will be migrated in the
process context and we don't do (and there is no need to) irq_chip mask/unmask
while migrating the interrupt.
Similarly fix the fixup_irqs() that get called during cpu offline and avoid
calling irq_chip mask/unmask for irqs that are ok to be migrated in the
process context.
While we didn't observe any race condition with the existing code,
this change takes complete advantage of interrupt-remapping in
the newer generation platforms and avoids any potential HW lockup's
(that often worry Eric :)
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
---
diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c
index 977d8b4..82265a5 100644
--- a/arch/x86/kernel/irq_64.c
+++ b/arch/x86/kernel/irq_64.c
@@ -95,7 +95,7 @@ void fixup_irqs(void)
affinity = cpu_all_mask;
}
- if (desc->chip->mask)
+ if (!(desc->status & IRQ_MOVE_PCNTXT) && desc->chip->mask)
desc->chip->mask(irq);
if (desc->chip->set_affinity)
@@ -103,7 +103,7 @@ void fixup_irqs(void)
else if (!(warned++))
set_affinity = 0;
- if (desc->chip->unmask)
+ if (!(desc->status & IRQ_MOVE_PCNTXT) && desc->chip->unmask)
desc->chip->unmask(irq);
spin_unlock(&desc->lock);
next reply other threads:[~2009-06-04 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 18:59 Suresh Siddha [this message]
2009-06-04 23:13 ` Eric W. Biederman
2009-06-05 1:18 ` Suresh Siddha
2009-06-05 1:19 ` Suresh Siddha
2009-06-05 1:47 ` Eric W. Biederman
2009-06-06 1:19 ` Suresh Siddha
2009-06-06 2:58 ` Eric W. Biederman
2009-06-05 22:20 ` Gary Hade
2009-06-06 0:57 ` Suresh Siddha
2009-06-06 23:37 ` Gary Hade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244141989.27006.10369.camel@localhost.localdomain \
--to=suresh.b.siddha@intel.com \
--cc=andi@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome