From: "Oskar Schirmer" <os@emlix.com>
To: Sascha Hauer <kernel@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Oskar Schirmer <os@emlix.com>, Fabian Godehardt <fg@emlix.com>
Subject: [PATCH 4/9 -v2] imx: serial: be sure to stop xmit upon shutdown
Date: Wed, 10 Jun 2009 14:08:31 +0200 [thread overview]
Message-ID: <1244635716-23315-5-git-send-email-os@emlix.com> (raw)
In-Reply-To: <1244635716-23315-1-git-send-email-os@emlix.com>
From: Fabian Godehardt <fg@emlix.com>
needed to avoid continued transmission by hardware
while software already shuts down, which might
cause dangling characters to show up in hardware
queues when restarting the device.
Signed-off-by: Fabian Godehardt <fg@emlix.com>
Signed-off-by: Oskar Schirmer <os@emlix.com>
---
drivers/serial/imx.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c
index afcec9e..3fa07a9 100644
--- a/drivers/serial/imx.c
+++ b/drivers/serial/imx.c
@@ -634,6 +634,10 @@ static void imx_shutdown(struct uart_port *port)
struct imx_port *sport = (struct imx_port *)port;
unsigned long temp;
+ temp = readl(sport->port.membase + UCR2);
+ temp &= ~(UCR2_TXEN);
+ writel(temp, sport->port.membase + UCR2);
+
/*
* Stop our timer.
*/
--
1.5.3.7
next prev parent reply other threads:[~2009-06-10 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 12:08 imx: serial: add IrDA support to serial driver Oskar Schirmer
2009-06-10 12:08 ` [PATCH 1/9 -v2] imx: serial: fix whitespaces (no changes in functionality) Oskar Schirmer
2009-06-10 12:08 ` [PATCH 2/9 -v2] imx: serial: fix one bit field type Oskar Schirmer
2009-06-10 12:08 ` [PATCH 3/9 -v2] imx: serial: notify higher layers in case xmit IRQ was not called Oskar Schirmer
2009-06-10 12:08 ` Oskar Schirmer [this message]
2009-06-10 12:08 ` [PATCH 5/9 -v2] imx: serial: handle initialisation failure correctly Oskar Schirmer
2009-06-10 12:08 ` [PATCH 6/9] lib: isolate rational fractions helper function Oskar Schirmer
2009-06-10 12:08 ` [PATCH 7/9 -v2] imx: serial: use rational library function Oskar Schirmer
2009-06-12 7:16 ` Sascha Hauer
2009-06-15 7:40 ` Oskar Schirmer
2009-06-15 8:15 ` Sascha Hauer
2009-06-10 12:08 ` [PATCH 8/9 -v2] imx: serial: add IrDA support to serial driver Oskar Schirmer
2009-06-10 12:08 ` [PATCH 9/9 -v2] imx: serial: use tty_encode_baud_rate to set true rate Oskar Schirmer
2009-06-16 7:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244635716-23315-5-git-send-email-os@emlix.com \
--to=os@emlix.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fg@emlix.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®