From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, cl@linux-foundation.org, mingo@elte.hu
Subject: Re: [PATCH] init: introduce mm_init()
Date: Thu, 11 Jun 2009 19:01:28 +0300 [thread overview]
Message-ID: <1244736088.4830.2.camel@penberg-laptop> (raw)
In-Reply-To: <alpine.LFD.2.01.0906110854450.3573@localhost.localdomain>
Hi Linus,
On Thu, 2009-06-11 at 08:56 -0700, Linus Torvalds wrote:
> Please just put the comments at the top of the function in cases like
> this, ie just
>
> /*
> * ...
> */
> static int __init mm_init(void)
> {
> ..
> }
Fixed.
On Thu, 2009-06-11 at 08:56 -0700, Linus Torvalds wrote:
> also, I'm now terminally confused about the whole series, so I'm wondering
> if you could re-do the series so that (a) I have a clear picture of what
> to take, and (b) preferably so it's also all bisectable (ie the trap_init
> ordering fixes are done in the initial mm/init.c changes).
Yup, I will do that and send a v3 of the pull request. I am compiling a
kernel here to try out my tree on 32-bit. I think Ingo is busy preparing
his remaining merges now so I haven't gotten confirmation from him
whether my patch fixes the problem he saw or not.
Pekka
next prev parent reply other threads:[~2009-06-11 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 15:47 Pekka J Enberg
2009-06-11 15:56 ` Linus Torvalds
2009-06-11 16:01 ` Pekka Enberg [this message]
2009-06-11 15:57 ` Christoph Lameter
2009-06-11 16:31 ` Pekka Enberg
2009-06-11 16:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244736088.4830.2.camel@penberg-laptop \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®